Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(231)

Issue 6308231068516352: Fix issues with security tokens (Enhanced Protected Mode, Protected Mode etc) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by Oleksandr
Modified:
5 years, 3 months ago
Reviewers:
Eric, Felix Dahlke
Visibility:
Public.

Description

This fixes the bug IE hanging when navigated to bing.com. The bug was caused by the fact that IE jumps out of AppContainer when navigating to bing.com. That caused us problems when communicating to AdblockPlusEngine. Key decisions implemented here: 1. Always run AdblockPlusEngine in low integrity 2. Give access to AdblockPlusEngine to all app containers. (IE and all Modern UI apps). Giving access to specific AppContainer seems to mark the process as part of that AppContainer, which in turn blocks all requests from out-of-appcontainer. 3. Mark the named pipe as low integrity resource explicitly for cases when engine was launched with higher integrity.

Patch Set 1 #

Total comments: 14

Patch Set 2 : Slaying the comments #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -46 lines) Patch
M src/plugin/AdblockPlusClient.cpp View 1 1 chunk +6 lines, -7 lines 0 comments Download
M src/shared/Communication.cpp View 1 6 chunks +14 lines, -32 lines 4 comments Download
M src/shared/Utils.h View 1 1 chunk +21 lines, -1 line 0 comments Download
M src/shared/Utils.cpp View 1 1 chunk +20 lines, -6 lines 2 comments Download

Messages

Total messages: 7
Oleksandr
5 years, 11 months ago (2013-11-15 19:33:51 UTC) #1
Felix Dahlke
IMO, in general it's not a big deal if we allow other processes to communicate ...
5 years, 10 months ago (2013-12-10 16:46:36 UTC) #2
Oleksandr
http://codereview.adblockplus.org/6308231068516352/diff/5629499534213120/src/plugin/AdblockPlusClient.cpp File src/plugin/AdblockPlusClient.cpp (right): http://codereview.adblockplus.org/6308231068516352/diff/5629499534213120/src/plugin/AdblockPlusClient.cpp#newcode52 src/plugin/AdblockPlusClient.cpp:52: else yes. bing.com (or any other website from the ...
5 years, 7 months ago (2014-03-04 10:40:05 UTC) #3
Felix Dahlke
Ah, got this one back from the dead, sorry for ignoring it after you addressed ...
5 years, 3 months ago (2014-06-24 15:30:38 UTC) #4
Eric
http://codereview.adblockplus.org/6308231068516352/diff/5998746462584832/src/shared/Communication.cpp File src/shared/Communication.cpp (right): http://codereview.adblockplus.org/6308231068516352/diff/5998746462584832/src/shared/Communication.cpp#newcode117 src/shared/Communication.cpp:117: PACL sacl; On 2014/06/24 15:30:39, Felix H. Dahlke wrote: ...
5 years, 3 months ago (2014-06-25 17:43:55 UTC) #5
Felix Dahlke
http://codereview.adblockplus.org/6308231068516352/diff/5998746462584832/src/shared/Communication.cpp File src/shared/Communication.cpp (right): http://codereview.adblockplus.org/6308231068516352/diff/5998746462584832/src/shared/Communication.cpp#newcode117 src/shared/Communication.cpp:117: PACL sacl; On 2014/06/25 17:43:55, Eric wrote: > On ...
5 years, 3 months ago (2014-06-27 14:35:56 UTC) #6
Oleksandr
5 years, 3 months ago (2014-07-02 09:08:02 UTC) #7
This codereview is already outdated. As a lot of the changes had to be reverted
and there's another review for these changes. Closing this.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5