Fix issues with security tokens (Enhanced Protected Mode, Protected Mode etc)

src/shared/Utils.cpp

 #include <memory>
 #include <stdexcept>
 #include <vector>
 
 #include <Windows.h>
 #include <ShlObj.h>
 
 #include "Utils.h"
 
 namespace
 {
   // See http://blogs.msdn.com/b/oldnewthing/archive/2004/10/25/247180.aspx
   EXTERN_C IMAGE_DOS_HEADER __ImageBase;
 
   std::wstring appDataPath;
 
 }
 
 bool IsWindowsVistaOrLater()
 {
   OSVERSIONINFOEX osvi;
   ZeroMemory(&osvi, sizeof(OSVERSIONINFOEX));
   osvi.dwOSVersionInfoSize = sizeof(OSVERSIONINFOEX);
   GetVersionEx(reinterpret_cast<LPOSVERSIONINFO>(&osvi));
   return osvi.dwMajorVersion >= 6;
 }
 
-bool IsWindows8()

[Felix Dahlke, 2013/12/10 16:46:36]

Shouldn't this be "isWindows8OrLater"?

+bool IsAppContainersSupported()
 {
-  OSVERSIONINFOEX osvi;
-  ZeroMemory(&osvi, sizeof(OSVERSIONINFOEX));
-  osvi.dwOSVersionInfoSize = sizeof(OSVERSIONINFOEX);
-  GetVersionEx(reinterpret_cast<LPOSVERSIONINFO>(&osvi));
-  return osvi.dwMajorVersion == 6 & osvi.dwMinorVersion >= 2;
+  //Try to allocate SID of AppContainer and see if it's succesful
+  PSID allAppContainersSid = 0;
+  SID_IDENTIFIER_AUTHORITY applicationAuthority = SECURITY_APP_PACKAGE_AUTHORITY;
+  BOOL res = AllocateAndInitializeSid(&applicationAuthority, 
+          SECURITY_BUILTIN_APP_PACKAGE_RID_COUNT,
+          SECURITY_APP_PACKAGE_BASE_RID,
+          SECURITY_BUILTIN_PACKAGE_ANY_PACKAGE,
+          0, 0, 0, 0, 0, 0,
+          &allAppContainersSid);
+
+  if (res == FALSE)

[Felix Dahlke, 2014/06/24 15:30:39]

I'd prefer !res here, but may just be me.

+  {
+    return false;
+  }
+  else

[Felix Dahlke, 2014/06/24 15:30:39]

From the Mozilla coding style which ours is based on: "Don't put an else right
after a return. Delete the else, it's unnecessary and increases indentation
level."

+  {
+    FreeSid(allAppContainersSid);
+    return true;
+  }
 }
 
 std::string ToUtf8String(const std::wstring& str)
 {
   int length = static_cast<int>(str.size());
   if (length == 0)
     return std::string();
 
   int utf8StringLength = WideCharToMultiByte(CP_UTF8, 0, str.c_str(), length, 0, 0, 0, 0);
   if (utf8StringLength == 0)
@@ skipping 76 matching lines @@
 }
 
 void ReplaceString(std::wstring& input, const std::wstring placeholder, const std::wstring replacement)
 {
   size_t replaceStart = input.find(placeholder);
   if (replaceStart != std::string::npos)
   {
     input.replace(replaceStart, placeholder.length(), replacement);
   }
 }