Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/notification.js

Issue 6322148272504832: Fixed: Transpiling of for-each in notification.js leads to error due to array modifications (Closed)
Patch Set: Created March 5, 2014, 4:38 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 324
325 /** 325 /**
326 * Notifies listeners about interactions with a notification 326 * Notifies listeners about interactions with a notification
327 * @param {String} id notification ID 327 * @param {String} id notification ID
328 * @param {Boolean} approved indicator whether notification has been approved or not 328 * @param {Boolean} approved indicator whether notification has been approved or not
329 */ 329 */
330 triggerQuestionListeners: function(id, approved) 330 triggerQuestionListeners: function(id, approved)
331 { 331 {
332 if (!(id in listeners)) 332 if (!(id in listeners))
333 return; 333 return;
334 for each (let listener in listeners[id]) 334 let questionListeners = listeners[id];
335 for each (let listener in questionListeners)
335 listener(approved); 336 listener(approved);
336 } 337 }
337 }; 338 };
338 Notification.init(); 339 Notification.init();
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld