Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(394)

Issue 6330303089999872: Issue 516 - JSHydra: return {foo:bar} produces broken code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 6 months ago by Wladimir Palant
Modified:
5 years, 6 months ago
Reviewers:
tschuster
Visibility:
Public.

Description

Issue 516 - JSHydra: return {foo:bar} produces broken code

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -13 lines) Patch
M autotest/abprewrite_source.js View 1 chunk +5 lines, -0 lines 0 comments Download
M autotest/test_abprewrite.js.expected View 1 chunk +17 lines, -6 lines 0 comments Download
M autotest/test_abprewrite_module.js.expected View 1 chunk +17 lines, -6 lines 0 comments Download
M scripts/abprewrite.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Wladimir Palant
5 years, 6 months ago (2014-05-19 06:59:00 UTC) #1
tschuster
5 years, 6 months ago (2014-05-19 11:16:30 UTC) #2
On 2014/05/19 06:59:00, Wladimir Palant wrote:
lgtm

I think there is actually a warning about this case in beautify.js
>This mode may break your scripts - e.g "return { a: 1 }" will be >broken into
two lines, so beware.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5