Issue 6330303089999872: Issue 516 - JSHydra: return {foo:bar} produces broken code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6330303089999872: Issue 516 - JSHydra: return {foo:bar} produces broken code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 6 months ago by Wladimir Palant

Modified:
5 years, 6 months ago

Reviewers:
tschuster

Visibility:
Public.

More Reviews

Description

Issue 516 - JSHydra: return {foo:bar} produces broken code

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -13 lines)			Patch
M	autotest/abprewrite_source.js	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	autotest/test_abprewrite.js.expected	View	1 chunk	+17 lines, -6 lines	0 comments	Download
M	autotest/test_abprewrite_module.js.expected	View	1 chunk	+17 lines, -6 lines	0 comments	Download
M	scripts/abprewrite.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

tschuster

5 years, 6 months ago (2014-05-19 11:16:30 UTC) #2

On 2014/05/19 06:59:00, Wladimir Palant wrote:
lgtm

I think there is actually a warning about this case in beautify.js
>This mode may break your scripts - e.g "return { a: 1 }" will be >broken into
two lines, so beware.

Expand All Messages | Collapse All Messages