safari/ext/background.js - Issue 6332121983483904: Issue 1824 - Removed unused method Page.activate()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: safari/ext/background.js

Issue 6332121983483904: Issue 1824 - Removed unused method Page.activate() (Closed)

Patch Set: Created Jan. 16, 2015, 1:28 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: safari/ext/background.js

===================================================================

--- a/safari/ext/background.js

+++ b/safari/ext/background.js

@@ -47,10 +47,6 @@

{

return this._frames[0].url;

- activate: function()

- {

- this._tab.activate();

- },

sendMessage: function(message, responseCallback)

{

this._messageProxy.sendMessage(message, responseCallback, {pageId: this._id});

@@ -671,10 +667,11 @@

for (var id in pages)

{

var page = pages[id];

+ var tab = page._tab;

- if (page.url == optionsUrl && page._tab.browserWindow == safari.application.activeBrowserWindow)

+ if (page.url == optionsUrl && tab.browserWindow == safari.application.activeBrowserWindow)

{

- page.activate();

+ tab.activate();

if (callback)

callback(page);

return;

« no previous file with comments | « chrome/ext/background.js ('k') | no next file » | no next file with comments »