Issue 1857 - Fixed issue where overlays were covered by elements with same z-index

include.postload.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 252 matching lines @@
     // "display" property is "none"), the overlay wouldn't match the element.
     if (style.display == "none")
       return null;
 
     // If the element or one of its ancestors uses fixed postioning, the overlay
     // has to use fixed postioning too. Otherwise it might not match the element.
     if (style.position == "fixed")
       position = "fixed";
 
     // Determine the effective z-index, which is the highest z-index used
-    // by the element and its offset ancestors. When using a lower z-index
-    // the element would cover the overlay. When using a higher z-index the
-    // overlay might also cover other elements.
+    // by the element and its offset ancestors, and increase it by one.
+    // When using a lower z-index the element would cover the overlay.
+    // When using a higher z-index the overlay might also cover other elements.
     if (style.position != "static" && style.zIndex != "auto")
     {
-      if (zIndex == "auto")
-        zIndex = style.zIndex;
-      else
-        zIndex = Math.max(zIndex, style.zIndex);
+      var curZIndex = parseInt(style.zIndex, 10) + 1;
+

[kzar, 2015/01/26 17:30:41]

Lol, whoops sorry! Missed that

+      if (zIndex == "auto" || curZIndex > zIndex)
+        zIndex = curZIndex;
     }
   }
 
   var overlay = document.createElement('div');
   overlay.prisoner = elt;
   overlay.className = "__adblockplus__overlay";
   overlay.setAttribute('style', 'opacity:0.4; display:inline-box; overflow:hidden; box-sizing:border-box;');
   var pos = getAbsolutePosition(elt);
   overlay.style.width = elt.offsetWidth + "px";
   overlay.style.height = elt.offsetHeight + "px";
@@ skipping 437 matching lines @@
           lastRightClickEventValid = false;
         else
           lastRightClickEvent = null;
         break;
     }
   });
 
   if (window == window.top)
     ext.backgroundPage.sendMessage({type: "report-html-page"});
 }