Issue 394 - hit statistics tool data collection

chrome/content/ui/filters-subscriptionview.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+let {FilterHits} = require("filterHits");
+
 /**
  * Fills a list of filter groups and keeps it updated.
  * @param {Element} list  richlistbox element to be filled
  * @param {Node} template  template to use for the groups
  * @param {Function} filter  filter to decide which lists should be included
  * @param {Function} listener  function to be called on changes
  * @constructor
  */
 function ListManager(list, template, filter, listener)
 {
@@ skipping 289 matching lines @@
   if (allow)
   {
     FilterStorage.addSubscription(subscription);
     if (subscription instanceof DownloadableSubscription && !subscription.lastDownload)
       Synchronizer.execute(subscription);
   }
   else
     FilterStorage.removeSubscription(subscription);
 };
 
-window.addEventListener("load", ListManager.init, false);
+/**
+ * Toggles option for sending filter hit statistics.
+ */
+function toggleSendStats(/**Boolean*/ allow)
+{
+  if (!allow)
+    FilterHits.resetFilterHits();

[Wladimir Palant, 2016/02/15 12:25:39]

Two notes:

1) I think this code is better placed in FilterHits itself, not the UI - it
should listen to Prefs.sendstats changes, regardless of how these changes were
performed.

2) I wonder whether we should clear the data immediately - what if the user
disables the pref only to enable it again immediately? We might be better off
waiting a second after a change.

[saroyanm, 2016/02/19 17:38:09]

Good point. Done.
Done.

+
+  Prefs.sendstats = allow;
+}

[Wladimir Palant, 2016/02/15 12:25:39]

This code doesn't really belong here - all the logic here is grouped under
ListManager and deals with filter subscriptions. I'd recommend putting it into
filters.js - unless you want to create a new file with a new container for it.

[saroyanm, 2016/02/19 17:38:10]

Done.

+
+window.addEventListener("load", function()
+{
+  ListManager.init();
+  E("sendStats").checked = Prefs.sendstats;

[Wladimir Palant, 2016/02/15 12:25:39]

What if Prefs.savestats isn't set? I think we don't want to show this checkbox
at all then.

[saroyanm, 2016/02/19 17:38:09]

Good point, Done.

+}, false);