Delta Between Two Patch Sets: lib/prefs.json
Issue 6337686776315904:
Issue 394 - hit statistics tool data collection (Closed)
Left Patch Set: Addressed Wladimir comments (bunch of changes)
Created March 18, 2016, 5:32 p.m.
Right Patch Set: Use Downloader to send the data to server
Created April 6, 2016, 3 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« lib/filterHits.js ('K')
|
« lib/filterHits.js ('k')
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 { | 1 { |
| 2 "defaults": { | 2 "defaults": { |
| 3 "currentVersion": "0.0", | 3 "currentVersion": "0.0", |
| 4 "enabled": true, | 4 "enabled": true, |
| 5 "frameobjects": true, | 5 "frameobjects": true, |
| 6 "fastcollapse": false, | 6 "fastcollapse": false, |
| 7 "showinstatusbar": false, | 7 "showinstatusbar": false, |
| 8 "detachsidebar": false, | 8 "detachsidebar": false, |
| 9 "defaulttoolbaraction": 0, | 9 "defaulttoolbaraction": 0, |
| 10 "defaultstatusbaraction": 0, | 10 "defaultstatusbaraction": 0, |
| (...skipping 10 matching lines...) Expand all Loading... | |
| 21 "subscriptions_autoupdate": true, | 21 "subscriptions_autoupdate": true, |
| 22 "subscriptions_listurl": "https://adblockplus.org/subscriptions2.xml", | 22 "subscriptions_listurl": "https://adblockplus.org/subscriptions2.xml", |
| 23 "subscriptions_fallbackurl": "https://adblockplus.org/getSubscription?versio n=%VERSION%&url=%SUBSCRIPTION%&downloadURL=%URL%&error=%ERROR%&channelStatus=%CH ANNELSTATUS%&responseStatus=%RESPONSESTATUS%", | 23 "subscriptions_fallbackurl": "https://adblockplus.org/getSubscription?versio n=%VERSION%&url=%SUBSCRIPTION%&downloadURL=%URL%&error=%ERROR%&channelStatus=%CH ANNELSTATUS%&responseStatus=%RESPONSESTATUS%", |
| 24 "subscriptions_fallbackerrors": 5, | 24 "subscriptions_fallbackerrors": 5, |
| 25 "subscriptions_exceptionsurl": "https://easylist-downloads.adblockplus.org/e xceptionrules.txt", | 25 "subscriptions_exceptionsurl": "https://easylist-downloads.adblockplus.org/e xceptionrules.txt", |
| 26 "subscriptions_exceptionscheckbox": true, | 26 "subscriptions_exceptionscheckbox": true, |
| 27 "documentation_link": "https://adblockplus.org/redirect?link=%LINK%&lang=%LA NG%", | 27 "documentation_link": "https://adblockplus.org/redirect?link=%LINK%&lang=%LA NG%", |
| 28 "savestats": true, | 28 "savestats": true, |
| 29 "sendstats": false, | 29 "sendstats": false, |
| 30 "sendstats_status": {}, | 30 "sendstats_status": {}, |
| 31 "sendstats_last_push": 0, | |
|
Wladimir Palant
2016/03/22 21:32:36
How about making last_push part of sendstats_statu
saroyanm
2016/04/06 15:15:43
Done, you think I can also make "sendstats" part o
| |
| 32 "sendstats_url": "https://telemetry.adblockplus.org/submit/adblockplus", | 31 "sendstats_url": "https://telemetry.adblockplus.org/submit/adblockplus", |
| 33 "composer_default": 2, | 32 "composer_default": 2, |
| 34 "clearStatsOnHistoryPurge": true, | 33 "clearStatsOnHistoryPurge": true, |
| 35 "report_submiturl": "https://reports.adblockplus.org/submitReport?version=1& guid=%GUID%&lang=%LANG%", | 34 "report_submiturl": "https://reports.adblockplus.org/submitReport?version=1& guid=%GUID%&lang=%LANG%", |
| 36 "recentReports": [], | 35 "recentReports": [], |
| 37 "hideContributeButton": false, | 36 "hideContributeButton": false, |
| 38 "blockableItemsSize": {"width": 200, "height": 200}, | 37 "blockableItemsSize": {"width": 200, "height": 200}, |
| 39 "notificationurl": "https://notification.adblockplus.org/notification.json", | 38 "notificationurl": "https://notification.adblockplus.org/notification.json", |
| 40 "notificationdata": {}, | 39 "notificationdata": {}, |
| 41 "subscriptions_antiadblockurl": "https://easylist-downloads.adblockplus.org/ antiadblockfilters.txt", | 40 "subscriptions_antiadblockurl": "https://easylist-downloads.adblockplus.org/ antiadblockfilters.txt", |
| 42 "please_kill_startup_performance": false, | 41 "please_kill_startup_performance": false, |
| 43 "suppress_first_run_page": false, | 42 "suppress_first_run_page": false, |
| 44 "notifications_showui": false, | 43 "notifications_showui": false, |
| 45 "notifications_ignoredcategories": [] | 44 "notifications_ignoredcategories": [] |
| 46 }, | 45 }, |
| 47 "preconfigurable": ["suppress_first_run_page"] | 46 "preconfigurable": ["suppress_first_run_page"] |
| 48 } | 47 } |
| LEFT | RIGHT |
« lib/filterHits.js ('k')
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
