Issue 301 - Change for each to for .. of .. in lib/

lib/filterStorage.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 99 matching lines @@
    */
   knownSubscriptions: {__proto__: null},
 
   /**
    * Finds the filter group that a filter should be added to by default. Will
    * return null if this group doesn't exist yet.
    */
   getGroupForFilter: function(/**Filter*/ filter) /**SpecialSubscription*/
   {
     let generalSubscription = null;
-    for each (let subscription in FilterStorage.subscriptions)
+    for (let subscription of FilterStorage.subscriptions)
     {
       if (subscription instanceof SpecialSubscription && !subscription.disabled)
       {
         // Always prefer specialized subscriptions
         if (subscription.isDefaultFor(filter))
           return subscription;
 
         // If this is a general subscription - store it as fallback
         if (!generalSubscription && (!subscription.defaults || !subscription.defaults.length))
           generalSubscription = subscription;
@@ skipping 209 matching lines @@
    * @param {Array of Filter} filters  filters to be reset, if null all filters will be reset
    */
   resetHitCounts: function(filters)
   {
     if (!filters)
     {
       filters = [];
       for (let text in Filter.knownFilters)
         filters.push(Filter.knownFilters[text]);
     }
-    for each (let filter in filters)
+    for (let filter of filters)
     {
       filter.hitCount = 0;
       filter.lastHit = 0;
     }
   },
 
   _loading: false,
 
   /**
    * Loads all subscriptions from the disk
@@ skipping 327 matching lines @@
 
 /**
  * Joins subscription's filters to the subscription without any notifications.
  * @param {Subscription} subscription filter subscription that should be connected to its filters
  */
 function addSubscriptionFilters(subscription)
 {
   if (!(subscription.url in FilterStorage.knownSubscriptions))
     return;
 
-  for each (let filter in subscription.filters)
+  for (let filter of subscription.filters)
     filter.subscriptions.push(subscription);
 }
 
 /**
  * Removes subscription's filters from the subscription without any notifications.
  * @param {Subscription} subscription filter subscription to be removed
  */
 function removeSubscriptionFilters(subscription)
 {
   if (!(subscription.url in FilterStorage.knownSubscriptions))
     return;
 
-  for each (let filter in subscription.filters)
+  for (let filter of subscription.filters)
   {
     let i = filter.subscriptions.indexOf(subscription);
     if (i >= 0)
       filter.subscriptions.splice(i, 1);
   }
 }
 
 /**
  * Observer listening to private browsing mode changes.
  * @class
@@ skipping 110 matching lines @@
             case "subscription":
               let subscription = Subscription.fromObject(this.curObj);
               if (subscription)
                 this.subscriptions.push(subscription);
               break;
             case "subscription filters":
             case "subscription patterns":
               if (this.subscriptions.length)
               {
                 let subscription = this.subscriptions[this.subscriptions.length - 1];
-                for each (let text in this.curObj)
+                for (let text of this.curObj)
                 {
                   let filter = Filter.fromText(text);
                   subscription.filters.push(filter);
                   filter.subscriptions.push(subscription);
                 }
               }
               break;
             case "user patterns":
               this.userFilters = this.curObj;
               break;
@@ skipping 32 matching lines @@
       Subscription.knownSubscriptions = origKnownSubscriptions;
     }
 
     // Allow events to be processed every now and then.
     // Note: IO.readFromFile() will deal with the potential reentrance here.
     this.linesProcessed++;
     if (this.linesProcessed % 1000 == 0)
       Utils.yield();
   }
 };