Issue 301 - Change for each to for .. of .. in lib/

lib/notification.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 110 matching lines @@
     Prefs.notificationdata.softExpiration = downloadable.softExpiration;
     Prefs.notificationdata.hardExpiration = downloadable.hardExpiration;
     saveNotificationData();
   },
 
   _onDownloadSuccess: function(downloadable, responseText, errorCallback, redirectCallback)
   {
     try
     {
       let data = JSON.parse(responseText);
-      for each (let notification in data.notifications)
+      for (let notification of data.notifications)
       {
         if ("severity" in notification)
         {
           if (!("type" in notification))
             notification.type = notification.severity;
           delete notification.severity;
         }
       }
       Prefs.notificationdata.data = data;
     }
@@ skipping 42 matching lines @@
       Prefs.notificationdata.shown = [];
       saveNotificationData();
     }
 
     let notifications = localData.concat(remoteData);
     if (notifications.length === 0)
       return null;
 
     let {addonName, addonVersion, application, applicationVersion, platform, platformVersion} = require("info");
     let notificationToShow = null;
-    for each (let notification in notifications)
+    for (let notification of notifications)
     {
       if ((typeof notification.type === "undefined" || notification.type !== "critical")
           && Prefs.notificationdata.shown.indexOf(notification.id) !== -1)
         continue;
 
       if (typeof url === "string" || notification.urlFilters instanceof Array)
       {
         if (typeof url === "string" && notification.urlFilters instanceof Array)
         {
           let matcher = new Matcher();
-          for each (let urlFilter in notification.urlFilters)
+          for (let urlFilter of notification.urlFilters)
             matcher.add(Filter.fromText(urlFilter));
           if (!matcher.matchesAny(url, "DOCUMENT", url))
             continue;
         }
         else
           continue;
       }
 
       if (notification.targets instanceof Array)
       {
         let match = false;
-        for each (let target in notification.targets)
+        for (let target of notification.targets)
         {
           if (checkTarget(target, "extension", addonName, addonVersion) &&
               checkTarget(target, "application", application, applicationVersion) &&
               checkTarget(target, "platform", platform, platformVersion))
           {
             match = true;
             break;
           }
         }
         if (!match)
@@ skipping 28 matching lines @@
    * @param {Object} notification notification to translate
    * @param {String} locale the target locale (optional, defaults to the
    *                        application locale)
    * @return {Object} the translated texts
    */
   getLocalizedTexts: function(notification, locale)
   {
     locale = locale || Utils.appLocale;
     let textKeys = ["title", "message"];
     let localizedTexts = [];
-    for each (let key in textKeys)
+    for (let key of textKeys)
     {
       if (key in notification)
       {
         if (typeof notification[key] == "string")
           localizedTexts[key] = notification[key];
         else
           localizedTexts[key] = localize(notification[key], locale);
       }
     }
     return localizedTexts;
@@ skipping 48 matching lines @@
   /**
    * Notifies listeners about interactions with a notification
    * @param {String} id notification ID
    * @param {Boolean} approved indicator whether notification has been approved or not
    */
   triggerQuestionListeners: function(id, approved)
   {
     if (!(id in listeners))
       return;
     let questionListeners = listeners[id];
-    for each (let listener in questionListeners)
+    for (let listener of questionListeners)
       listener(approved);
   }
 };
 Notification.init();