Issue 301 - Change for each to for .. of .. in lib/

lib/ui.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 878 matching lines @@
 
     let match = /^abp:\/*subscribe\/*\?(.*)/i.exec(linkTarget);
     if (!match)
       return;
 
     // Decode URL parameters
     let title = null;
     let url = null;
     let mainSubscriptionTitle = null;
     let mainSubscriptionURL = null;
-    for each (let param in match[1].split('&'))
+    for (let param of match[1].split('&'))
     {
       let parts = param.split("=", 2);
       if (parts.length != 2 || !/\S/.test(parts[1]))
         continue;
       switch (parts[0])
       {
         case "title":
           title = decodeURIComponent(parts[1]);
           break;
         case "location":
@@ skipping 406 matching lines @@
     function E(id) window.document.getElementById(id);
 
     let node = window.document.tooltipNode;
     if (!node || !node.hasAttribute("tooltip"))
     {
       event.preventDefault();
       return;
     }
 
     // Prevent tooltip from overlapping menu
-    for each (let id in ["abp-toolbar-popup", "abp-status-popup"])
+    for (let id of ["abp-toolbar-popup", "abp-status-popup"])
     {
       let element = E(id);
       if (element && element.state == "open")
       {
         event.preventDefault();
         return;
       }
     }
 
     let type = (node.id == "abp-toolbarbutton" ? "toolbar" : "statusbar");
@@ skipping 447 matching lines @@
     }
   },
 
   /**
    * Hide contribute button and persist this choice.
    */
   hideContributeButton: function(/**Window*/ window)
   {
     Prefs.hideContributeButton = true;
 
-    for each (let id in ["abp-status-contributebutton", "abp-toolbar-contributebutton", "abp-menuitem-contributebutton"])
+    for (let id of ["abp-status-contributebutton", "abp-toolbar-contributebutton", "abp-menuitem-contributebutton"])
     {
       let button = window.document.getElementById(id);
       if (button)
         button.hidden = true;
     }
   },
 
   showNextNotification: function(url)
   {
     let window = this.currentWindow;
@@ skipping 39 matching lines @@
 
       insertMessage(element, after, links);
     }
 
     let texts = Notification.getLocalizedTexts(notification);
     let titleElement = window.document.getElementById("abp-notification-title");
     titleElement.textContent = texts.title;
     let messageElement = window.document.getElementById("abp-notification-message");
     messageElement.innerHTML = "";
     let docLinks = [];
-    for each (let link in notification.links)
+    for (let link of notification.links)
       docLinks.push(Utils.getDocLink(link));
     insertMessage(messageElement, texts.message, docLinks);
 
     messageElement.addEventListener("click", function(event)
     {
       let link = event.target;
       while (link && link !== messageElement && link.localName !== "a")
         link = link.parentNode;
       if (!link || link.localName !== "a")
         return;
@@ skipping 47 matching lines @@
   ["abp-command-contribute", "command", UI.openContributePage.bind(UI)],
   ["abp-command-contribute-hide", "command", UI.hideContributeButton.bind(UI)]
 ];
 
 onShutdown.add(function()
 {
   for (let window in UI.applicationWindows)
     if (UI.isBottombarOpen(window))
       UI.toggleBottombar(window);
 });