metadata.common - Issue 6346177440120832: Added abstraction for frames, to fix domain-based rules, whitelisting and ad counter on Safari

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.common

Issue 6346177440120832: Added abstraction for frames, to fix domain-based rules, whitelisting and ad counter on Safari (Closed)

Left Patch Set: Created Dec. 21, 2013, 7:48 p.m.

Right Patch Set: Addressed another comment Created Jan. 20, 2014, 8:50 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [general]	1 [general]

	2 version = 1.7.2

2 backgroundScripts = ext/common.js	3 backgroundScripts = ext/common.js

3 ext/background.js	4 ext/background.js

4 lib/compat.js	5 lib/compat.js

5 lib/info.js	6 lib/info.js

6 lib/io.js	7 lib/io.js

7 lib/adblockplus.js	8 lib/adblockplus.js

8 lib/punycode.js	9 lib/punycode.js

9 lib/publicSuffixList.js	10 lib/publicSuffixList.js

10 lib/basedomain.js	11 lib/basedomain.js

11 lib/sha1.js	12 lib/sha1.js

(...skipping 83 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
95 addSubscription.label	96 addSubscription.label

96 addSubscriptionAdd.label	97 addSubscriptionAdd.label

97 addSubscriptionOther.label	98 addSubscriptionOther.label

98 acceptableAds2.label	99 acceptableAds2.label

99 viewList.label	100 viewList.label

100 readMore.label	101 readMore.label

101 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label	102 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label

102 title.label	103 title.label

103 adblockplus/chrome/locale/*/meta.properties = =name	104 adblockplus/chrome/locale/*/meta.properties = =name

104 adblockplus/chrome/locale//firstRun.properties = =	105 adblockplus/chrome/locale//firstRun.properties = =

LEFT	RIGHT