Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: chrome/content/ui/filters-filterview.js

Issue 6363941206753280: Issue 594 - Typo in preferences window tooltip for the slow filters column (Closed)
Patch Set: Created June 2, 2014, 9:09 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 11 matching lines...) Expand all
22 * subscription. 22 * subscription.
23 * @class 23 * @class
24 */ 24 */
25 var FilterView = 25 var FilterView =
26 { 26 {
27 /** 27 /**
28 * Initialization function. 28 * Initialization function.
29 */ 29 */
30 init: function() 30 init: function()
31 { 31 {
32 // "Manually" remove access key for col-slow tooltip, Utils.splitAllLabels()
33 // won't do it.
34 let slowColumn = document.getElementById("col-slow");
35 if (slowColumn)
36 {
37 for (let attr of ["display", "tooltiptext"])
38 {
39 let value = slowColumn.getAttribute(attr);
40 if (!value)
41 continue;
42 let [label, accessKey] = Utils.splitLabel(value);
43 if (label != value)
44 slowColumn.setAttribute(attr, label);
45 }
46 }
47
32 if (this.sortProcs) 48 if (this.sortProcs)
33 return; 49 return;
34 50
35 function compareText(/**Filter*/ filter1, /**Filter*/ filter2) 51 function compareText(/**Filter*/ filter1, /**Filter*/ filter2)
36 { 52 {
37 if (filter1.text < filter2.text) 53 if (filter1.text < filter2.text)
38 return -1; 54 return -1;
39 else if (filter1.text > filter2.text) 55 else if (filter1.text > filter2.text)
40 return 1; 56 return 1;
41 else 57 else
(...skipping 782 matching lines...) Expand 10 before | Expand all | Expand 10 after
824 getProgressMode: function() null, 840 getProgressMode: function() null,
825 getImageSrc: function() null, 841 getImageSrc: function() null,
826 isSeparator: function() false, 842 isSeparator: function() false,
827 performAction: function() {}, 843 performAction: function() {},
828 performActionOnRow: function() {}, 844 performActionOnRow: function() {},
829 performActionOnCell: function() {}, 845 performActionOnCell: function() {},
830 getCellValue: function() null, 846 getCellValue: function() null,
831 setCellValue: function() {}, 847 setCellValue: function() {},
832 selectionChanged: function() {}, 848 selectionChanged: function() {},
833 }; 849 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld