Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(170)

Issue 6364489058353152: Issue 2126 - Adapted CMS for living in its own repository rather than sitescripts (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by Wladimir Palant
Modified:
4 years, 6 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 2126 - Adapted CMS for living in its own repository rather than sitescripts

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Added .pyo to ignore files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -17 lines) Patch
A .gitignore View 1 1 chunk +4 lines, -0 lines 0 comments Download
A .hgignore View 1 1 chunk +6 lines, -0 lines 0 comments Download
M cms/bin/generate_static_pages.py View 3 chunks +14 lines, -7 lines 0 comments Download
M cms/bin/test_server.py View 2 chunks +2 lines, -4 lines 0 comments Download
M cms/converters.py View 2 chunks +2 lines, -2 lines 0 comments Download
M runserver.py View 1 chunk +2 lines, -2 lines 0 comments Download
M runserver.spec View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
Wladimir Palant
4 years, 7 months ago (2015-03-11 20:23:08 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/6364489058353152/diff/5741031244955648/.hgignore File .hgignore (right): http://codereview.adblockplus.org/6364489058353152/diff/5741031244955648/.hgignore#newcode5 .hgignore:5: *.pyc Mind .pyo files (created instead when running python ...
4 years, 7 months ago (2015-03-12 09:49:20 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/6364489058353152/diff/5741031244955648/.hgignore File .hgignore (right): http://codereview.adblockplus.org/6364489058353152/diff/5741031244955648/.hgignore#newcode5 .hgignore:5: *.pyc On 2015/03/12 09:49:21, Sebastian Noack wrote: > Mind ...
4 years, 7 months ago (2015-03-12 16:22:52 UTC) #3
Sebastian Noack
LGTM
4 years, 7 months ago (2015-03-12 17:36:29 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/6364489058353152/diff/5741031244955648/.hgignore File .hgignore (right): http://codereview.adblockplus.org/6364489058353152/diff/5741031244955648/.hgignore#newcode5 .hgignore:5: *.pyc On 2015/03/12 16:22:52, Wladimir Palant wrote: > On ...
4 years, 7 months ago (2015-03-12 21:00:52 UTC) #5
Wladimir Palant
4 years, 7 months ago (2015-03-12 21:08:34 UTC) #6
http://codereview.adblockplus.org/6364489058353152/diff/5741031244955648/.hgi...
File .hgignore (right):

http://codereview.adblockplus.org/6364489058353152/diff/5741031244955648/.hgi...
.hgignore:5: *.pyc
On 2015/03/12 21:00:53, Sebastian Noack wrote:
> Those are the only repos I have access to with .hgignore files considering
> Python.

Quite frankly, it is probably enough if we do this for sitescripts. As to
everything else, I don't see why anybody would use the -O command line flag
there.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5