Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: chrome/devtools/devtools.html
Issue
6393086494113792
:
Issue 154 - Added devtools panel showing blocked and blockable items (Closed)
Patch Set:
Created Jan. 4, 2015, 9:48 p.m.
Left:
Base
Patch Set 1:
Patch Set 2: Added some newlines for better legibility
Patch Set 3: Use unprefixed flexbox
Patch Set 4: Moved UI to adblockplusui repo
Patch Set 5: Rebased, use regular messaging, added some comments
Patch Set 6: Rebased
Patch Set 7: Rebased and fixed documentation mistakenly indicating arguments as optional
Patch Set 8: Rebased
Patch Set 9: Rebased and fixed various issues
Patch Set 10: Rebased and refactored
Patch Set 11: Made onFilterChanged handler more legible, removed debug console.log, fixed type of type
Patch Set 12: Updated dependencies
Patch Set 13: Fixed issues in content script breaking element hide tracing
Patch Set 14: Addressed comments, fixed popup blocking detection, log whitelisted documents
Patch Set 15: Use chrome.runtime.onConnect directly
Patch Set 16: Fixed a typo, updated dependency, tidied up some code
Patch Set 17: Fixed typo in JSDoc syntax
Patch Set 18: Adapt for UI changes generating domain specific filters when necessary
Right:
Patch Set 1:
Patch Set 2: Added some newlines for better legibility
Patch Set 3: Use unprefixed flexbox
Patch Set 4: Moved UI to adblockplusui repo
Patch Set 5: Rebased, use regular messaging, added some comments
Patch Set 6: Rebased
Patch Set 7: Rebased and fixed documentation mistakenly indicating arguments as optional
Patch Set 8: Rebased
Patch Set 9: Rebased and fixed various issues
Patch Set 10: Rebased and refactored
Patch Set 11: Made onFilterChanged handler more legible, removed debug console.log, fixed type of type
Patch Set 12: Updated dependencies
Patch Set 13: Fixed issues in content script breaking element hide tracing
Patch Set 14: Addressed comments, fixed popup blocking detection, log whitelisted documents
Patch Set 15: Use chrome.runtime.onConnect directly
Patch Set 16: Fixed a typo, updated dependency, tidied up some code
Patch Set 17: Fixed typo in JSDoc syntax
Patch Set 18: Adapt for UI changes generating domain specific filters when necessary
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
background.js
chrome/devtools/devtools.html
chrome/devtools/devtools.js
chrome/devtools/devtools-panel.css
chrome/devtools/devtools-panel.html
chrome/devtools/devtools-panel.js
include.preload.js
lib/devtools.js
metadata.chrome
metadata.common
popupBlocker.js
webrequest.js
View unified diff
|
Download patch
« no previous file with comments
|
« background.js
('k') |
chrome/devtools/devtools.js »
('j') |
chrome/devtools/devtools-panel.js »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<script type="application/javascript" src="devtools.js"></script>
OLD
NEW
« no previous file with comments
|
« background.js
('k') |
chrome/devtools/devtools.js »
('j') |
chrome/devtools/devtools-panel.js »
('J')
Edit Message
Issue 6393086494113792: Issue 154 - Added devtools panel showing blocked and blockable items (Closed)
Created Dec. 28, 2014, 4:38 p.m. by Sebastian Noack
Modified Feb. 3, 2016, 5:05 p.m.
Reviewers kzar
Base URL:
Comments: 32
+ 2 drafts
This is Rietveld
Issue 6393086494113792:
Issue 154 - Added devtools panel showing blocked and blockable items (Closed)
