metadata.common - Issue 6393086494113792: Issue 154 - Added devtools panel showing blocked and blockable items

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.common

Issue 6393086494113792: Issue 154 - Added devtools panel showing blocked and blockable items (Closed)

Left Patch Set: Made onFilterChanged handler more legible, removed debug console.log, fixed type of type Created Jan. 30, 2016, 3:42 p.m.

Right Patch Set: Adapt for UI changes generating domain specific filters when necessary Created Feb. 3, 2016, 10:40 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [general]	1 [general]

2 version = 1.10	2 version = 1.10.1

3 backgroundScripts = lib/polyfills/url.js	3 backgroundScripts = lib/polyfills/url.js

4 lib/polyfills/promise.js	4 lib/polyfills/promise.js

5 lib/polyfills/fetch.js	5 lib/polyfills/fetch.js

6 ext/common.js	6 ext/common.js

7 ext/background.js	7 ext/background.js

8 lib/compat.js	8 lib/compat.js

9 lib/info.js	9 lib/info.js

10 lib/adblockplus.js	10 lib/adblockplus.js

11 lib/punycode.js	11 lib/punycode.js

12 lib/publicSuffixList.js	12 lib/publicSuffixList.js

(...skipping 70 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
83 adblockplus/lib/filterStorage.js	83 adblockplus/lib/filterStorage.js

84 adblockplus/lib/elemHide.js	84 adblockplus/lib/elemHide.js

85 adblockplus/lib/matcher.js	85 adblockplus/lib/matcher.js

86 adblockplus/lib/cssRules.js	86 adblockplus/lib/cssRules.js

87 adblockplus/lib/filterListener.js	87 adblockplus/lib/filterListener.js

88 adblockplus/lib/synchronizer.js	88 adblockplus/lib/synchronizer.js

89 adblockplus/lib/notification.js	89 adblockplus/lib/notification.js

90 adblockplus/lib/antiadblockInit.js	90 adblockplus/lib/antiadblockInit.js

91 lib/url.js	91 lib/url.js

92 lib/stats.js	92 lib/stats.js

	93 lib/devtools.js

93 lib/whitelisting.js	94 lib/whitelisting.js

94 lib/filterValidation.js	95 lib/filterValidation.js

95 lib/filterComposer.js	96 lib/filterComposer.js

96 lib/icon.js	97 lib/icon.js

97 lib/notificationHelper.js	98 lib/notificationHelper.js

98 lib/uninstall.js	99 lib/uninstall.js

99 lib/devtools.js

100 --arg module=true source_repo=https://hg.adblockplus.org/adblockplus/	100 --arg module=true source_repo=https://hg.adblockplus.org/adblockplus/

101 ext/common.js = ext/common.js chrome/ext/common.js	101 ext/common.js = ext/common.js chrome/ext/common.js

102 ext/background.js = ext/background.js chrome/ext/background.js --arg brace_style =expand	102 ext/background.js = ext/background.js chrome/ext/background.js --arg brace_style =expand

103	103

104 qunit/tests/adblockplus.js = adblockplustests/chrome/content/tests/domainRestric tions.js	104 qunit/tests/adblockplus.js = adblockplustests/chrome/content/tests/domainRestric tions.js

105 adblockplustests/chrome/content/tests/filterClasses.js	105 adblockplustests/chrome/content/tests/filterClasses.js

106 adblockplustests/chrome/content/tests/filterNotifier.js	106 adblockplustests/chrome/content/tests/filterNotifier.js

107 adblockplustests/chrome/content/tests/filterStorage.js	107 adblockplustests/chrome/content/tests/filterStorage.js

108 adblockplustests/chrome/content/tests/matcher.js	108 adblockplustests/chrome/content/tests/matcher.js

109 adblockplustests/chrome/content/tests/prefs.js	109 adblockplustests/chrome/content/tests/prefs.js

(...skipping 25 matching lines...) Expand all Loading...
135 addSubscription.label	135 addSubscription.label

136 addSubscriptionAdd.label	136 addSubscriptionAdd.label

137 addSubscriptionOther.label	137 addSubscriptionOther.label

138 acceptableAds2.label	138 acceptableAds2.label

139 viewList.label	139 viewList.label

140 readMore.label	140 readMore.label

141 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label	141 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label

142 title.label	142 title.label

143 adblockplus/chrome/locale/*/meta.properties = =name	143 adblockplus/chrome/locale/*/meta.properties = =name

144 adblockplusui/locale//firstRun.json = =	144 adblockplusui/locale//firstRun.json = =

LEFT	RIGHT