Issue 154 - Added devtools panel showing blocked and blockable items

chrome/ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 513 matching lines @@
           }
 
           return frames[0];
         }
       };
     }
 
     return ext.onMessage._dispatch(message, sender, sendResponse).indexOf(true) != -1;
   });
 
-  // We have to ensure there is at least one listener for the onConnect event.
-  // Otherwise we can't connect a port later, which we need to do in order to
-  // detect when the extension is reloaded, disabled or uninstalled.
-  chrome.runtime.onConnect.addListener(function() {});
-
 
   /* Storage */
 
   ext.storage = {
     get: function(keys, callback)
     {
       chrome.storage.local.get(keys, callback);
     },
     set: function(key, value, callback)
     {
@@ skipping 35 matching lines @@
           if (callback)
             callback(new Page(tab));
         }
         else
         {
           ext.pages.open(optionsUrl, callback);
         }
       });
     });
   };
-
-
-  /* Devtools panel */
-
-  var Panel = function(inspectedTabId, port)
-  {
-    this.inspectedTabId = inspectedTabId;
-    this._port = port;
-  };
-  Panel.prototype = {
-    sendMessage: function(message)
-    {
-      this._port.postMessage(message);
-    },
-    get onRemoved()
-    {
-      return this._port.onDisconnect;
-    }
-  };
-
-  ext.devtools = {
-    onCreated: new ext._EventTarget()
-  };
-
-  // If this code should ever be removed, note that we still have to
-  // ensure that there is at least one listener for the onConnect event.
-  // Otherwise we can't connect a port later, in order to detect when
-  // the extension is reloaded,disabled or uninstalled.
-  chrome.runtime.onConnect.addListener(function(port)
-  {
-    var match = port.name.match(/^devtools-(\d+)$/);
-    if (match)
-    {
-      var panel = new Panel(parseInt(match[1], 10), port);

[kzar, 2016/01/31 13:33:51]

Nit: Maybe should use let instead of var for these variables?

[Sebastian Noack, 2016/02/02 10:39:51]

I'd rather keep things conistent. (Except for one inconsistency introduced by
you) we don't use block-scoping in this file or generally in ext.

-      ext.devtools.onCreated._dispatch(panel);
-    }
-  });
 })();