Issue 154 - Added devtools panel showing blocked and blockable items

include.preload.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 194 matching lines @@
     document.addEventListener("DOMContentLoaded", this.trace);
   else
     this.trace();
 }
 ElementHidingTracer.prototype = {
   checkNodes: function(nodes)
   {
     var matchedSelectors = [];
 
     // Find all selectors that match any hidden element inside the given nodes.
     for (var i = 0; i < this.selectors.length; i++)

[kzar, 2016/01/31 13:33:51]

Nit: Could you use `for ... of ...` for these loops instead?

[Sebastian Noack, 2016/02/02 10:39:52]

This is a content script. So there is no jsHydra magic.

[kzar, 2016/02/02 15:42:09]

Acknowledged.

     {
       var selector = this.selectors[i];
 
       for (var j = 0; j < nodes.length; j++)
       {
         var elements = nodes[j].querySelectorAll(selector);
         var matched = false;
 
         for (var k = 0; k < elements.length; k++)
         {
           // Only consider selectors that actually have an effect on the
           // computed styles, and aren't overridden by rules with higher
           // priority, or haven't been circumvented in a different way.
           if (getComputedStyle(elements[k]).display == "none")
           {
             matchedSelectors.push(selector);
             matched = true;
             break;
           }
         }
 
         if (matched)
           break;
       }
     }
 
     if (matchedSelectors.length > 0)
-      ext.backgroundPage.sendMessage({type: "trace-elemhide", selectors: matchedSelectors});

[kzar, 2016/01/31 13:33:51]

Nit: Mind wrapping this long line?

[Sebastian Noack, 2016/02/02 10:39:52]

Done.

+      ext.backgroundPage.sendMessage({
+        type: "trace-elemhide",
+        selectors: matchedSelectors
+      });
   },
 
   onTimeout: function()
   {
     this.checkNodes(this.changedNodes);
     this.changedNodes = [];
     this.timeout = null;
   },
 
   observe: function(mutations)
@@ skipping 295 matching lines @@
           // document_start content scripts (like this one) don't
           // run either in those frames due to https://crbug.com/416907.
           // So we have to apply element hiding from the parent frame.
           if (!("init" in contentWindow))
             init(contentDocument);
 
           // Moreover, "load" and "error" events aren't dispatched for elements
           // in dynamically created frames due to https://crbug.com/442107.
           // So we also have to apply element collpasing from the parent frame.
           if (!contentWindow.collapsing)
-            [].forEach.call(contentDocument.querySelectorAll(Object.keys(typeMap).join(",")), checkCollapse);
+            Array.prototype.forEach.call(
+              contentDocument.querySelectorAll(Object.keys(typeMap).join(",")),
+              checkCollapse
+            );
         }
       }
     }
   }, true);
 
   return updateStylesheet;
 }
 
 if (document instanceof HTMLDocument)
 {
   checkSitekey();
   window.updateStylesheet = init(document);
 }