Issue 154 - Added devtools panel showing blocked and blockable items

lib/devtools.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 23 matching lines @@
 {
   return Object.keys(panels).length > 0;
 }
 
 function getActivePanel(page)
 {
   let panel = panels[page._id];
   if(panel && !panel.reload && !panel.reloading)
     return panel;
   return null;
-}
-
-function getRequestInfo(request)
-{
-  return {
-    url: request.url,
-    type: request.type,
-    docDomain: request.docDomain
-  };
 }
 
 function getFilterInfo(filter)
 {
   if (!filter)
     return null;
 
   let userDefined = false;
   let subscriptionTitle = null;
 
@@ skipping 32 matching lines @@
     (record.filter && record.filter.selector) == (filter && filter.selector)
   );
 }
 
 function addRecord(panel, request, filter)
 {
   if (!hasRecord(panel, request, filter))
   {
     panel.port.postMessage({
       type: "add-record",
-      request: getRequestInfo(request),
+      request: request,
       filter: getFilterInfo(filter)
     });
 
     panel.records.push({
       request: request,
       filter: filter
     });
   }
 }
 
 function matchRequest(request)
 {
   return defaultMatcher.matchesAny(
     request.url,
     RegExpFilter.typeMap[request.type],
     request.docDomain,
     request.thirdParty,
     request.sitekey,
     request.specificOnly
   );
 }
 
 /**
  * Logs a request to the devtools panel.
  *
  * @param {Page}     page          The page the request occured on
- * @param {string]   url           The URL of the request

[kzar, 2016/02/02 15:42:11]

Nit: Typo here `{string]`

[Sebastian Noack, 2016/02/02 16:33:46]

Done.

+ * @param {string}   url           The URL of the request
  * @param {string}   type          The request type
  * @param {string}   docDomain     The IDN-decoded hostname of the document
  * @param {boolean}  thirdParty    Whether the origin of the request and document differs
  * @param {?string}  sitekey       The active sitekey if there is any

[kzar, 2016/02/02 15:42:11]

Nit: Isn't the syntax for optional parameters `@param {type} [name] ...`?

[Sebastian Noack, 2016/02/02 16:33:46]

{?string} means "string or null", which seems to be more accurrate, as we always
call logRequest() with all arguments, but we might get null here (as well as for
the other two arguments below).

[kzar, 2016/02/02 16:40:31]

Acknowledged.

  * @param {?boolean} specificOnly  Whether generic filters should be ignored
  * @param {?BlockingFilter} filter The matched filter or null if there is no match
  */
 exports.logRequest = function(page, url, type, docDomain,
                               thirdParty, sitekey,
                               specificOnly, filter)
 {
   let panel = getActivePanel(page);
   if (panel)
   {
@@ skipping 48 matching lines @@
  * @param {Page}         page      The page the whitelisting is active on
  * @param {string}       url       The url of the whitelisted document
  * @param {number}       typeMask  The bit mask of whitelisting types checked for
  * @param {string}       docDomain The IDN-decoded hostname of the parent document
  * @param {WhitelistFilter} filter The matched whitelisting filter
  */
 exports.logWhitelistedDocument = function(page, url, typeMask, docDomain, filter)
 {
   let panel = getActivePanel(page);
   if (panel)
   {

[kzar, 2016/02/02 15:42:10]

Nit: We don't need the braces here and for the for loop below. (I don't mind too
much, up to you.)

[Sebastian Noack, 2016/02/02 16:33:47]

Well, according to the Wladimir-ish notation for using braces, braces are
required for readability when the content of a block requires more than one
line. I don't always agree to that though.

[kzar, 2016/02/02 16:40:31]

Acknowledged.

     for (let type of nonRequestTypes)
     {
       if (typeMask & filter.contentType & RegExpFilter.typeMap[type])
         addRecord(panel, {url: url, type: type, docDomain: docDomain}, filter);
     }
   }
 };
 
 /**
  * Checks whether a page is inspected by the devtools panel.
@@ skipping 121 matching lines @@
           panel.records.splice(i--, 1);
           continue;
         }
 
         record.filter = matchRequest(record.request);
       }
 
       panel.port.postMessage({
         type: "update-record",
         index: i,
-        request: getRequestInfo(record.request),
+        request: record.request,
         filter: getFilterInfo(record.filter)
       });
     }
   }
 }
 
 chrome.runtime.onConnect.addListener(port =>
 {
   let match = port.name.match(/^devtools-(\d+)$/);
   if (!match)
@@ skipping 24 matching lines @@
 
     if (!hasPanels())
     {
       FilterNotifier.removeListener(onFilterChange);
       ext.pages.onLoading.removeListener(onLoading);
     }
   });
 
   panels[inspectedTabId] = {port: port, records: []};
 });