Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: popupBlocker.js

Issue 6393086494113792: Issue 154 - Added devtools panel showing blocked and blockable items (Closed)
Left Patch Set: Rebased and fixed various issues Created March 12, 2015, 3:32 p.m.
Right Patch Set: Adapt for UI changes generating domain specific filters when necessary Created Feb. 3, 2016, 10:40 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « popup.js ('k') | webrequest.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 var logRequest = require("devtools").logRequest;
19
20 if (require("info").platform == "chromium") 18 if (require("info").platform == "chromium")
21 { 19 {
20 var logRequest = require("devtools").logRequest;
22 var tabsLoading = {}; 21 var tabsLoading = {};
23 22
24 chrome.webNavigation.onCreatedNavigationTarget.addListener(function(details) 23 chrome.webNavigation.onCreatedNavigationTarget.addListener(function(details)
25 { 24 {
26 var sourcePage = new ext.Page({id: details.sourceTabId}); 25 var sourcePage = new ext.Page({id: details.sourceTabId});
27 var sourceFrame = ext.getFrame(details.sourceTabId, details.sourceFrameId); 26 var sourceFrame = ext.getFrame(details.sourceTabId, details.sourceFrameId);
28 27
29 if (!sourceFrame || isFrameWhitelisted(sourcePage, sourceFrame)) 28 if (checkWhitelisted(sourcePage, sourceFrame))
30 return; 29 return;
31 30
32 var documentHost = extractHostFromFrame(sourceFrame); 31 var documentHost = extractHostFromFrame(sourceFrame);
33 if (!documentHost) 32 if (!documentHost)
34 return; 33 return;
35 34
36 tabsLoading[details.tabId] = {page: sourcePage, host: documentHost}; 35 var specificOnly = !!checkWhitelisted(sourcePage, sourceFrame,
37 checkPotentialPopup(details.tabId, details.url, sourcePage, documentHost); 36 RegExpFilter.typeMap.GENERICBLOCK);
37
38 tabsLoading[details.tabId] = {
39 page: sourcePage,
40 documentHost: documentHost,
41 specificOnly: specificOnly
42 };
43 checkPotentialPopup(details.tabId, details.url, sourcePage, documentHost, sp ecificOnly);
38 }); 44 });
39 45
40 chrome.tabs.onUpdated.addListener(function(tabId, changeInfo, tab) 46 chrome.tabs.onUpdated.addListener(function(tabId, changeInfo, tab)
41 { 47 {
42 var opener = tabsLoading[tabId]; 48 if (!(tabId in tabsLoading))
43 if (!opener) 49 {
50 // Not a pop-up we've previously seen
44 return; 51 return;
52 }
45 53
46 if ("url" in changeInfo) 54 if ("url" in changeInfo)
47 checkPotentialPopup(tabId, tab.url, opener.page, opener.host); 55 {
56 var source = tabsLoading[tabId];
57 checkPotentialPopup(tabId, tab.url, source.page,
58 source.documentHost,
59 source.specificOnly);
60 }
48 61
49 if ("status" in changeInfo && changeInfo.status == "complete" && tab.url != "about:blank") 62 if ("status" in changeInfo && changeInfo.status == "complete" && tab.url != "about:blank")
50 delete tabsLoading[tabId]; 63 delete tabsLoading[tabId];
51 }); 64 });
52 } 65 }
53 66
54 function checkPotentialPopup(tabId, url, sourcePage, documentHost) 67 function checkPotentialPopup(tabId, url, sourcePage, documentHost, specificOnly)
55 { 68 {
56 url = new URL(url || "about:blank"); 69 var urlObj = new URL(url || "about:blank");
70 var urlString = stringifyURL(urlObj);
71 var thirdParty = isThirdParty(urlObj, documentHost);
57 72
58 var urlString = stringifyURL(url); 73 var filter = defaultMatcher.matchesAny(
59 var thirdParty = isThirdParty(url, documentHost); 74 urlString, RegExpFilter.typeMap.POPUP,
60 var filter = defaultMatcher.matchesAny(urlString, "POPUP", documentHost, third Party); 75 documentHost, thirdParty, null, specificOnly
76 );
61 77
62 if (filter instanceof BlockingFilter) 78 if (filter instanceof BlockingFilter)
63 chrome.tabs.remove(tabId); 79 chrome.tabs.remove(tabId);
64 80
65 logRequest(sourcePage, urlString, "POPUP", documentHost, thirdParty, null, fi lter); 81 logRequest(
82 sourcePage, urlString, "POPUP", documentHost,
83 thirdParty, null, specificOnly, filter
84 );
66 } 85 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld