Issue 2610 - Return notification version in a response header

sitescripts/notifications/test/notification.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2015 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 283 matching lines @@
     load_notifications_call.return_value = []
     notification.notification({"QUERY_STRING": "lastVersion="},
                               lambda *args: None)
     notification.notification({"QUERY_STRING": "lastVersion=-"},
                               lambda *args: None)
     notification.notification({"QUERY_STRING": "lastVersion=-/"},
                               lambda *args: None)
     notification.notification({"QUERY_STRING": "lastVersion=-//"},
                               lambda *args: None)
 
+  @mock.patch("sitescripts.notifications.web.notification.load_notifications")
+  def test_version_header_present(self, load_notifications_call):
+    load_notifications_call.return_value = [{"id": "1"}]
+    response_header_map = {}
+    def start_response(status, response_headers):
+      for name, value in response_headers:

[Sebastian Noack, 2015/06/02 22:35:47]

Not much simpler, but here you go:

  response_header_map = None
  def start_response(status, response_headers):
    response_header_map = dict(response_headers)

[Felix Dahlke, 2015/06/03 03:21:07]

I've tried this before - unfortunately it doesn't work because I cannot assign
to a variable from the parent scope, apparently. That's why I'm initialising the
dict in the parent scope and just add elements to it in the function, but it
feels like a hack.

+        response_header_map[name] = value
+    result = json.loads(notification.notification({}, start_response))
+    self.assertEqual(result["version"],
+                     response_header_map["ABP-Notification-Version"])
+
 if __name__ == '__main__':
   unittest.main()