test_server.py - Issue 6427347985104896: Issue 1663 - Making first-run page testable in the adblockplusui repository

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: test_server.py

Issue 6427347985104896: Issue 1663 - Making first-run page testable in the adblockplusui repository (Closed)

Left Patch Set: Created Dec. 16, 2014, 2:05 p.m.

Right Patch Set: Addressed comments Created Dec. 17, 2014, 2:19 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #!/usr/bin/env python	1 #!/usr/bin/env python

2	2

3 # This file is part of the Adblock Plus <https://adblockplus.org/>,	3 # This file is part of Adblock Plus <http://adblockplus.org/>,
Thomas Greiner 2014/12/17 11:24:44 Interestingly, you used the HTTPS version of adblo Interestingly, you used the HTTPS version of adblockplus.org here while we still use the HTTP version in (most) other files. We should change that in all other headers at some point but for this review I'd consider it inconsistent. Wladimir Palant 2014/12/17 13:00:38 Yes, I noticed the wrong URL - I want to fix it ev Show quoted text On 2014/12/17 11:24:44, Thomas Greiner wrote: > Interestingly, you used the HTTPS version of http://adblockplus.org here while we still > use the HTTP version in (most) other files. We should change that in all other > headers at some point but for this review I'd consider it inconsistent. Yes, I noticed the wrong URL - I want to fix it everywhere else in January when we'll have to update the copyright year anyway. Thomas Greiner 2014/12/17 13:43:40 Makes sense. BTW it says "of the Adblock Plus" whi Show quoted text On 2014/12/17 13:00:38, Wladimir Palant wrote: > On 2014/12/17 11:24:44, Thomas Greiner wrote: > > Interestingly, you used the HTTPS version of http://adblockplus.org here while > we still > > use the HTTP version in (most) other files. We should change that in all other > > headers at some point but for this review I'd consider it inconsistent. > > Yes, I noticed the wrong URL - I want to fix it everywhere else in January when > we'll have to update the copyright year anyway. Makes sense. BTW it says "of the Adblock Plus" which is "of Adblock Plus" in the other files.
4 # Copyright (C) 2006-2014 Eyeo GmbH	4 # Copyright (C) 2006-2014 Eyeo GmbH

5 #	5 #

6 # Adblock Plus is free software: you can redistribute it and/or modify	6 # Adblock Plus is free software: you can redistribute it and/or modify

7 # it under the terms of the GNU General Public License version 3 as	7 # it under the terms of the GNU General Public License version 3 as

8 # published by the Free Software Foundation.	8 # published by the Free Software Foundation.

9 #	9 #

10 # Adblock Plus is distributed in the hope that it will be useful,	10 # Adblock Plus is distributed in the hope that it will be useful,

11 # but WITHOUT ANY WARRANTY; without even the implied warranty of	11 # but WITHOUT ANY WARRANTY; without even the implied warranty of

12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

13 # GNU General Public License for more details.	13 # GNU General Public License for more details.

14 #	14 #

15 # You should have received a copy of the GNU General Public License	15 # You should have received a copy of the GNU General Public License

16 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.	16 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

17	17

18 import flask	18 import os

	19 import SimpleHTTPServer

	20 import SocketServer

19	21

20 app = flask.Flask(__name__, static_url_path='', static_folder='')	22 PORT = ("127.0.0.1", 5000)

	23

	24 httpd = SocketServer.TCPServer(PORT, SimpleHTTPServer.SimpleHTTPRequestHandler)

21	25

22 if __name__ == "__main__":	26 if __name__ == "__main__":

23 app.run(debug=True)	27 print "Starting web server at http://%s:%i/" % PORT

	28 os.chdir(os.path.dirname(__file__))

	29 httpd.serve_forever()

LEFT	RIGHT