Issue 616 - Add tests for $generichide and $genericblock

chrome/content/tests/filterClasses.js

Index: chrome/content/tests/filterClasses.js
diff --git a/chrome/content/tests/filterClasses.js b/chrome/content/tests/filterClasses.js
index 7b9afdf6cbd63a91b824b58031273ceb833c99e7..ca2f25124628c5eb124076185bae8e64f9994e09 100644
--- a/chrome/content/tests/filterClasses.js
+++ b/chrome/content/tests/filterClasses.js
@@ -92,7 +92,8 @@
     }
     if (type == "whitelist" || type == "filterlist")
     {
-      addProperty("contentType", 0x7FFFFFFF & ~(RegExpFilter.typeMap.DOCUMENT | RegExpFilter.typeMap.ELEMHIDE | RegExpFilter.typeMap.POPUP));
+      addProperty("contentType", 0x7FFFFFFF & ~(RegExpFilter.typeMap.DOCUMENT | RegExpFilter.typeMap.ELEMHIDE | RegExpFilter.typeMap.POPUP |

[Thomas Greiner, 2015/10/01 16:12:04]

Detail: If you think that the 80 characters rule should not be applied here,
that's fine with me but the way it breaks now is suboptimal as shown below.

How it looks like without line wraps:

call(abc | def | ghi |
     jkl | mno);

How it looks like in an environment limited to 80 characters (e.g. Rietveld):

call(abc |
def | ghi |
     jkl
 | mno);

[kzar, 2015/10/02 10:19:28]

Most of these test files are pretty bad when it comes to following the 80
character rule and often it's probably for the best. I agree with you here
though, was no trouble to make it look a bit nicer. Done.

[Thomas Greiner, 2015/10/02 13:55:47]

Thanks, I appreciate that.

+                                                RegExpFilter.typeMap.GENERICHIDE | RegExpFilter.typeMap.GENERICBLOCK));
       addProperty("matchCase", "false");
       addProperty("thirdParty", "null");
       addProperty("domains", "");
@@ -197,7 +198,7 @@
   });
 
   let t = RegExpFilter.typeMap;
-  let defaultTypes = 0x7FFFFFFF & ~(t.ELEMHIDE | t.DOCUMENT | t.POPUP);
+  let defaultTypes = 0x7FFFFFFF & ~(t.ELEMHIDE | t.DOCUMENT | t.POPUP | t.GENERICHIDE | t.GENERICBLOCK);
 
   test("Special characters", function()
   {