Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6440550915899392: Issue 2139 - Allow nested translations for tag attributes. (Closed)

Created:
April 16, 2015, 10:53 a.m. by kzar
Modified:
April 23, 2015, 3:26 p.m.
CC:
saroyanm
Visibility:
Public.

Description

Issue 2139 - Allow nested translations for tag attributes.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use complex regexp instead of keeping track of nested levels ourselves. #

Patch Set 3 : Rebased on top of Wladimir's changes for link resolving. #

Total comments: 2

Patch Set 4 : Improved regexp some more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M cms/converters.py View 1 2 3 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 9
kzar
Patch Set 1
April 16, 2015, 10:54 a.m. (2015-04-16 10:54:40 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/6440550915899392/diff/5629499534213120/cms/converters.py File cms/converters.py (right): http://codereview.adblockplus.org/6440550915899392/diff/5629499534213120/cms/converters.py#newcode194 cms/converters.py:194: r"\{\{\s*([\w\-]+)(?:\[(.*?)\])?\s+(.*)\}\}", Only one nesting level is actually allowed here. ...
April 16, 2015, 9:01 p.m. (2015-04-16 21:01:13 UTC) #2
kzar
http://codereview.adblockplus.org/6440550915899392/diff/5629499534213120/cms/converters.py File cms/converters.py (right): http://codereview.adblockplus.org/6440550915899392/diff/5629499534213120/cms/converters.py#newcode194 cms/converters.py:194: r"\{\{\s*([\w\-]+)(?:\[(.*?)\])?\s+(.*)\}\}", On 2015/04/16 21:01:13, Wladimir Palant wrote: > Only ...
April 21, 2015, 11:28 a.m. (2015-04-21 11:28:57 UTC) #3
kzar
Patch Set 2 : Use complex regexp instead of keeping track of nested levels ourselves. ...
April 21, 2015, 2:44 p.m. (2015-04-21 14:44:53 UTC) #4
kzar
Patch Set 3 : Rebased on top of Wladimir's changes for link resolving.
April 21, 2015, 4:21 p.m. (2015-04-21 16:21:04 UTC) #5
Sebastian Noack
LGTM
April 22, 2015, 7:43 a.m. (2015-04-22 07:43:51 UTC) #6
Wladimir Palant
http://codereview.adblockplus.org/6440550915899392/diff/5170986005561344/cms/converters.py File cms/converters.py (right): http://codereview.adblockplus.org/6440550915899392/diff/5170986005561344/cms/converters.py#newcode182 cms/converters.py:182: r"((?:[^\{]|\{(?!\{)|\{\{(?:[^\}]|\}(?!\}))*?\}\})*?)" # Translatable text Yes, this line isn't very ...
April 22, 2015, 1:52 p.m. (2015-04-22 13:52:23 UTC) #7
kzar
Patch Set 4 : Improved regexp some more http://codereview.adblockplus.org/6440550915899392/diff/5170986005561344/cms/converters.py File cms/converters.py (right): http://codereview.adblockplus.org/6440550915899392/diff/5170986005561344/cms/converters.py#newcode182 cms/converters.py:182: r"((?:[^\{]|\{(?!\{)|\{\{(?:[^\}]|\}(?!\}))*?\}\})*?)" ...
April 22, 2015, 2:46 p.m. (2015-04-22 14:46:06 UTC) #8
Wladimir Palant
April 22, 2015, 8:38 p.m. (2015-04-22 20:38:33 UTC) #9
LGTM

Powered by Google App Engine
This is Rietveld