Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(446)

Issue 6463903206735872: Issue 1606 - Don't create overlays for hidden elements (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by Sebastian Noack
Modified:
5 years, 1 month ago
Reviewers:
Wladimir Palant, kzar
Visibility:
Public.

Description

Issue 1606 - Don't create overlays for hidden elements

Patch Set 1 #

Patch Set 2 : Use offsetParent #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M include.postload.js View 1 1 chunk +6 lines, -0 lines 3 comments Download

Messages

Total messages: 6
Sebastian Noack
5 years, 1 month ago (2014-11-25 16:30:40 UTC) #1
Sebastian Noack
I just figured out that I can just use Element.offsetParent, which always returns null in ...
5 years, 1 month ago (2014-11-25 17:17:06 UTC) #2
kzar
LGTM, I just tested out offsetParent and it seems to work exactly as you described.
5 years, 1 month ago (2014-11-26 08:41:26 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/6463903206735872/diff/5741031244955648/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/6463903206735872/diff/5741031244955648/include.postload.js#newcode205 include.postload.js:205: // "diplay" property is "none"), the overlay wouldn't match ...
5 years, 1 month ago (2014-11-26 13:10:18 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/6463903206735872/diff/5741031244955648/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/6463903206735872/diff/5741031244955648/include.postload.js#newcode206 include.postload.js:206: if (!elt.offsetParent) On 2014/11/26 13:10:18, Wladimir Palant wrote: > ...
5 years, 1 month ago (2014-11-26 13:15:07 UTC) #5
Wladimir Palant
5 years, 1 month ago (2014-11-26 17:17:43 UTC) #6
LGTM but I think you should fix the typo anyway.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5