Issue 1606 - Don't create overlays for hidden elements

include.postload.js

Index: include.postload.js
===================================================================
--- a/include.postload.js
+++ b/include.postload.js
@@ -200,6 +200,12 @@
   // because we don't know how to construct a filter rule for it
   if(!hasFilters(elt))
     return;
+
+  // If the element isn't rendered (since its or one of its ancestor's
+  // "diplay" property is "none"), the overlay wouldn't match the element.

[Wladimir Palant, 2014/11/26 13:10:18]

Nit: "display"

+  if (!elt.offsetParent)

[Wladimir Palant, 2014/11/26 13:10:18]

What about elements that use visibility:hidden or height:0? I think it makes
more sense to test offsetWidth == 0 || offsetHeight == 0.

[Sebastian Noack, 2014/11/26 13:15:07]

We don't have to bother about those. In that case the overlay will be placed as
expected, covering the area (if any) of the element it was created for.

However if display is set to none, and an overlay would be created, it would
cover random other elements.

+    return;
+
   var thisStyle = getComputedStyle(elt, null);
   var overlay = document.createElement('div');
   overlay.prisoner = elt;