Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6467101665525760: Noissue - Use named functions in lib/whitelisting.js for consistency (Closed)

Created:
Jan. 21, 2015, 7:58 a.m. by Sebastian Noack
Modified:
Jan. 22, 2015, 9:57 a.m.
Reviewers:
kzar
Visibility:
Public.

Description

Noissue - Use named functions in lib/whitelisting.js for consistency

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M lib/whitelisting.js View 7 chunks +15 lines, -11 lines 2 comments Download

Messages

Total messages: 4
Sebastian Noack
Jan. 21, 2015, 7:59 a.m. (2015-01-21 07:59:11 UTC) #1
kzar
http://codereview.adblockplus.org/6467101665525760/diff/5629499534213120/lib/whitelisting.js File lib/whitelisting.js (right): http://codereview.adblockplus.org/6467101665525760/diff/5629499534213120/lib/whitelisting.js#newcode50 lib/whitelisting.js:50: function getKey(page, frame) Shouldn't getKey be declared before isFrameWhitelisted?
Jan. 21, 2015, 2:12 p.m. (2015-01-21 14:12:55 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/6467101665525760/diff/5629499534213120/lib/whitelisting.js File lib/whitelisting.js (right): http://codereview.adblockplus.org/6467101665525760/diff/5629499534213120/lib/whitelisting.js#newcode50 lib/whitelisting.js:50: function getKey(page, frame) On 2015/01/21 14:12:55, kzar wrote: > ...
Jan. 21, 2015, 2:24 p.m. (2015-01-21 14:24:49 UTC) #3
kzar
Jan. 21, 2015, 2:25 p.m. (2015-01-21 14:25:42 UTC) #4
OK, otherwise LGTM

Powered by Google App Engine
This is Rietveld