Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6484340657618944: Issue 2168 - Unbreak web2 configuration (Closed)

Created:
March 18, 2015, 8:16 p.m. by Wladimir Palant
Modified:
March 18, 2015, 8:48 p.m.
Reviewers:
mathias
Visibility:
Public.

Description

Issue 2168 - Unbreak web2 configuration

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M manifests/webserver.pp View 1 chunk +1 line, -5 lines 0 comments Download
M modules/private-stub/hiera/hosts.yaml View 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 3
Wladimir Palant
March 18, 2015, 8:16 p.m. (2015-03-18 20:16:29 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/6484340657618944/diff/5629499534213120/modules/private-stub/hiera/hosts.yaml File modules/private-stub/hiera/hosts.yaml (right): http://codereview.adblockplus.org/6484340657618944/diff/5629499534213120/modules/private-stub/hiera/hosts.yaml#newcode45 modules/private-stub/hiera/hosts.yaml:45: ssh_public_key: AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBDhC6a20iZh6VurNrRC3ZzdilTp6yelnzJ8/49ujHvkAC38Rj6870re3Yvkg+8AfxdyVNP8owqC6x7KQD0zJ6Nk= This is bogus of course - it's ...
March 18, 2015, 8:17 p.m. (2015-03-18 20:17:39 UTC) #2
mathias
March 18, 2015, 8:20 p.m. (2015-03-18 20:20:59 UTC) #3
LGTM.

http://codereview.adblockplus.org/6484340657618944/diff/5629499534213120/modu...
File modules/private-stub/hiera/hosts.yaml (right):

http://codereview.adblockplus.org/6484340657618944/diff/5629499534213120/modu...
modules/private-stub/hiera/hosts.yaml:45: ssh_public_key:
AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBDhC6a20iZh6VurNrRC3ZzdilTp6yelnzJ8/49ujHvkAC38Rj6870re3Yvkg+8AfxdyVNP8owqC6x7KQD0zJ6Nk=
On 2015/03/18 20:17:39, Wladimir Palant wrote:
> This is bogus of course - it's the SSH key of the production server. But it's
> the same for all hosts here.

Indeed, I'll look into that in another context. The recent migration should
allow us to clean up a lot of similar stuff as well.

Powered by Google App Engine
This is Rietveld