Issue 6499942772244480: Reload popover on Safari every time it is shown

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6499942772244480: Reload popover on Safari every time it is shown (Closed)

Created:
Jan. 23, 2014, 10:20 a.m. by Sebastian Noack

Modified:
Jan. 23, 2014, 2 p.m.

Reviewers:
Felix Dahlke, Wladimir Palant

Visibility:
Public.

Description

On Chrome the bubble is loaded when it is shown. However on Safari the bubble is loaded only once. First I thought it would be sufficient to reload the bubble on Safari when it is shown for a different tab. But more cases had recently to be added. Now I just realized two more cases when the bubble must be reloaded, one is when a new page was loaded in the tab, and the other when the bubble was shown for the new tab page on Safari 7.0 before. So by now I think it makes most sense (in favor of a simpler and more robust approach) to just reload the bubble every time it is shown.

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -23 lines)			Patch
	M	safari/ext/popup.js	View	1 2	3 chunks	+16 lines, -23 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Wladimir Palant

Nice simplification, there is really no point overdoing this. LGTM but see nit below. http://codereview.adblockplus.org/6499942772244480/diff/5741031244955648/safari/ext/popup.js ...

Jan. 23, 2014, 1:40 p.m. (2014-01-23 13:40:54 UTC) #2

Sebastian Noack

Jan. 23, 2014, 2 p.m. (2014-01-23 14:00:34 UTC) #3

http://codereview.adblockplus.org/6499942772244480/diff/5741031244955648/safa...
File safari/ext/popup.js (right):

http://codereview.adblockplus.org/6499942772244480/diff/5741031244955648/safa...
safari/ext/popup.js:18: var mayResize = true;
On 2014/01/23 13:40:54, Wladimir Palant wrote:
> Nit: I don't really like this variable being used before declaration in
popover
> listener, even though this is valid in JavaScript. Maybe move the popover
> listener down?

Done.

Expand All Messages | Collapse All Messages