Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include.postload.js

Issue 6500163518464000: Issue 1612 - Remove prisoner when user blocks an element with an overlay (Closed)
Patch Set: Created Nov. 26, 2014, 12:31 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include.postload.js
===================================================================
--- a/include.postload.js
+++ b/include.postload.js
@@ -713,11 +713,12 @@
}
break;
case "clickhide-close":
- if (clickHideFiltersDialog)
+ if (clickHideFiltersDialog && msg.remove)
{
// Explicitly get rid of currentElement
- if (msg.remove && currentElement && currentElement.parentNode)
- currentElement.parentNode.removeChild(currentElement);
+ var element = currentElement.prisoner || currentElement;
+ if (element && element.parentNode)
+ element.parentNode.removeChild(element);
}
clickHide_deactivate();
break;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld