Issue 1109 - Support notifications

src/engine/NotificationWindow.h

-#pragma once
+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-2015 Eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef NOTIFICATION_WINDOW_H
+#define NOTIFICATION_WINDOW_H
+
 #include <atlbase.h>
 #include <atlwin.h>
 #include <atlctl.h>
 #include <atlimage.h>
 #include <AdblockPlus/JsValue.h>
 #include <AdblockPlus/Notification.h>
 #include <functional>
 #include <MsHtmdid.h>
 
 class IconStaticControl : public ATL::CWindow
@@ skipping 65 matching lines @@
 
   operator bool() const
   {
     return m_handle == nullptr;
   }
 protected:
   T m_handle;
 private:
   ScopedObjectHandle(const ScopedObjectHandle&);
   ScopedObjectHandle& operator=(const ScopedObjectHandle&);
-};
-
-class CFont : public ScopedObjectHandle<HFONT>
-{
-public:
-  explicit CFont(HFONT hFont = nullptr) : ScopedObjectHandle(hFont)
-  {
-  }
-
-  void CreateFontIndirect(const LOGFONT* logFontArg, uint32_t dpi)
-  {
-    ATLASSERT(m_handle == nullptr);
-    LOGFONT logFont = *logFontArg;
-    logFont.lfHeight = -MulDiv(dpi, logFont.lfHeight, 72);

[Oleksandr, 2015/07/22 09:45:36]

I really don't see us going over the max int size with dpi * logFont.lfHeight
multiplication here. What's the reasoning behind using MulDiv instead of regular
multiplication? Would be more readable without MulDiv, IMHO. Also, I think "*
(-1)" is a more readable negation. 

[sergei, 2015/07/23 14:17:58]

We don't need CFont I forgot to remove it, I used it at the very first version
for title.

-    m_handle = ::CreateFontIndirect(&logFont);
-  }
 };
 
 class CBrush : public ScopedObjectHandle<HBRUSH>
 {
 public:
   explicit CBrush(HBRUSH brush = nullptr) : ScopedObjectHandle(brush)
   {
   }
 
   void CreateSolidBrush(COLORREF crColor)
@@ skipping 173 matching lines @@
 private:
   LRESULT OnCreate(const CREATESTRUCT* createStruct);
   void OnSize(uint32_t wParam, CSize size);
   LRESULT OnClick(UINT msg, WPARAM wParam, LPARAM lParam, BOOL& handled);
 
   void OnFinalMessage(HWND) override;
 
   // returns {windowX, windowY} of top left corner on the monitor
   POINT GetWindowCoordinates();
 private:
-  // m_content is used a holder of all children and we need it to have a border.

[Oleksandr, 2015/07/22 09:45:36]

NIT: "used AS a holder"

+  // m_content is used as a holder of all children and we need it to have a border.
   // It seems the most correct way to have a border to set WS_POPUPWINDOW style
   // and paint the border in WM_NCPAINT but it simply does not work here.
   NotificationWindow m_content;
   std::function<void()> m_onDestroyedCallback;
-};
+};
+#endif