Issue #276 - eliminate CString from CPluginMutex

src/plugin/PluginMutex.h

Index: src/plugin/PluginMutex.h
===================================================================
--- a/src/plugin/PluginMutex.h
+++ b/src/plugin/PluginMutex.h
@@ -10,11 +10,11 @@
   HANDLE m_hMutex;
   bool m_isLocked;
   int m_errorSubidBase;
-  CString m_name;
+  std::wstring system_name;

[sergei, 2014/08/05 11:56:22]

Why is it renamed?

Firstly it is the name of mutex and the class is called mutex, so the member
`m_name` means "the name of mutex". I don't see any reason to rename it.
Especially what is the "system"? There is no any system in this class. The
prefix 'm_' is used to distinguish between members and other variables, and it's
used for other members.

[Eric, 2014/08/05 12:56:18]

Because I'm saving the rest of the renames for another patch set to isolate the
changes that might have a functional effect.
"The" name implies uniqueness, which is just wrong here. There are four
different names running around here:
- A user designated name, a base name
- The name of an operating system mutex, with some prefix.
- A specific name for global scope
- A specific name for local scope

If you noticed, I changed the recorded name in the member to be the system name
rather than the base name. Since it's the member name that's logged if there's
an error on release, this small change improves logging by indicating the scope
of the system mutex that was changed. If it weren't for logging, there would be
no need to keep the name around as a member variable at all.
The operating system. There is always a system when you make system calls.

 
 public:
 
-  CPluginMutex(const CString& name, int errorSubidBase);
+  CPluginMutex(const std::wstring& name, int errorSubidBase);
   ~CPluginMutex();
 
   bool IsLocked() const;