Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(232)

Issue 6526453483044864: Issue 2193 - Added notification opt-out (Firefox) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by Thomas Greiner
Modified:
4 years, 3 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 2193 - Added notification opt-out (Firefox)

Patch Set 1 #

Patch Set 2 : Rebased to 5434ef6e1545 #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -13 lines) Patch
M chrome/content/ui/overlay.xul View 3 chunks +17 lines, -7 lines 0 comments Download
M chrome/content/ui/settings.xul View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/locale/en-US/overlay.dtd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/skin/overlay.css View 3 chunks +20 lines, -3 lines 0 comments Download
M lib/ui.js View 1 2 4 chunks +26 lines, -3 lines 0 comments Download

Messages

Total messages: 4
Thomas Greiner
Note that I've intentionally used a look that's more native to Firefox than what you ...
4 years, 6 months ago (2015-04-14 15:23:45 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/6526453483044864/diff/29321066/lib/ui.js File lib/ui.js (right): https://codereview.adblockplus.org/6526453483044864/diff/29321066/lib/ui.js#newcode133 lib/ui.js:133: this.value = (Prefs.notifications_ignoredcategories.indexOf("*") == -1); Nit: toggleIgnoreCategory() should really ...
4 years, 3 months ago (2015-06-26 13:13:09 UTC) #2
Thomas Greiner
https://codereview.adblockplus.org/6526453483044864/diff/29321066/lib/ui.js File lib/ui.js (right): https://codereview.adblockplus.org/6526453483044864/diff/29321066/lib/ui.js#newcode133 lib/ui.js:133: this.value = (Prefs.notifications_ignoredcategories.indexOf("*") == -1); On 2015/06/26 13:13:09, Wladimir ...
4 years, 3 months ago (2015-06-26 15:32:49 UTC) #3
Wladimir Palant
4 years, 3 months ago (2015-06-27 06:52:33 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5