ext/background.js - Issue 6528746257383424: Issue 1708 - Integrate first-run page changes in Chrome/Opera/Safari

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: ext/background.js

Issue 6528746257383424: Issue 1708 - Integrate first-run page changes in Chrome/Opera/Safari (Closed)

Patch Set: Addressed comment Created Dec. 19, 2014, 7:37 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: ext/background.js

===================================================================

--- a/ext/background.js

+++ b/ext/background.js

@@ -17,27 +17,31 @@

(function()

{

var nonEmptyPageMaps = {__proto__: null};

var pageMapCounter = 0;

var PageMap = ext.PageMap = function()

{

- this._map = {__proto__: null};

+ this._map = Object.create(null);

this._id = ++pageMapCounter;

};

PageMap.prototype = {

_delete: function(id)

{

delete this._map[id];

if (Object.keys(this._map).length == 0)

delete nonEmptyPageMaps[this._id];

+ keys: function()

+ {

+ return Object.keys(this._map).map(ext._getPage);

+ },

get: function(page)

{

return this._map[page._id];

set: function(page, value)

{

this._map[page._id] = value;

nonEmptyPageMaps[this._id] = this;