Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(416)

Issue 6533470486528000: Issue 2510 - Support Adblock Browser (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Felix Dahlke
Modified:
4 years, 9 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 2510 - Support Adblock Browser

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Update ensure_dependencies.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -11 lines) Patch
M chrome.manifest View 1 chunk +1 line, -1 line 0 comments Download
M dependencies View 1 chunk +1 line, -1 line 0 comments Download
M ensure_dependencies.py View 1 6 chunks +37 lines, -8 lines 0 comments Download
M lib/appSupport.js View 1 chunk +1 line, -0 lines 0 comments Download
M lib/objectTabs.js View 1 chunk +2 lines, -1 line 0 comments Download
M metadata.gecko View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
Felix Dahlke
As discussed before, at least one change here shouldn't be required for Adblock Browser. Still, ...
4 years, 9 months ago (2015-05-12 20:51:50 UTC) #1
Wladimir Palant
Changing dependencies file shouldn't be necessary if you don't patch buildtools (see other review). Other ...
4 years, 9 months ago (2015-05-15 19:19:00 UTC) #2
Wladimir Palant
Never mind, didn't realize that this is the final fix rather than the quick and ...
4 years, 9 months ago (2015-05-15 19:30:36 UTC) #3
Felix Dahlke
Updating ensure_dependencies.py here, as discussed.
4 years, 9 months ago (2015-05-15 19:34:41 UTC) #4
Wladimir Palant
4 years, 9 months ago (2015-05-15 19:53:28 UTC) #5
LGTM again.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5