Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(197)

Issue 6541524925939712: Issue 2197 - [cms] Update PyInstaller configuration (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by Wladimir Palant
Modified:
4 years, 6 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Note that this relies on #2196 which is currently under review.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M runserver.spec View 1 chunk +12 lines, -1 line 3 comments Download

Messages

Total messages: 4
Wladimir Palant
4 years, 7 months ago (2015-03-20 22:32:29 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/6541524925939712/diff/5629499534213120/runserver.spec File runserver.spec (right): http://codereview.adblockplus.org/6541524925939712/diff/5629499534213120/runserver.spec#newcode12 runserver.spec:12: 'werkzeug', Are you sure we should exclude werkzeug from ...
4 years, 7 months ago (2015-03-21 11:26:48 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/6541524925939712/diff/5629499534213120/runserver.spec File runserver.spec (right): http://codereview.adblockplus.org/6541524925939712/diff/5629499534213120/runserver.spec#newcode12 runserver.spec:12: 'werkzeug', On 2015/03/21 11:26:48, Sebastian Noack wrote: > Are ...
4 years, 7 months ago (2015-03-21 11:36:34 UTC) #3
Sebastian Noack
4 years, 7 months ago (2015-03-21 12:51:45 UTC) #4
LGTM

http://codereview.adblockplus.org/6541524925939712/diff/5629499534213120/runs...
File runserver.spec (right):

http://codereview.adblockplus.org/6541524925939712/diff/5629499534213120/runs...
runserver.spec:12: 'werkzeug',
On 2015/03/21 11:36:34, Wladimir Palant wrote:
> On 2015/03/21 11:26:48, Sebastian Noack wrote:
> > Are you sure we should exclude werkzeug from the builds? It's debugger is
very
> > helpful.
> 
> It pulls in lots of dependencies, and the debugger isn't really helpful for
> people who run the standalone build (meaning: the merely want to test their
> changes).

Fair enough.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5