Issue 119 - Switch to injecting CSS for element hiding

src/plugin/PluginFilter.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginFilter.h"
 #include "PluginSettings.h"
 #include "PluginClient.h"
 #include "PluginClientFactory.h"
 #include "PluginMutex.h"
 #include "PluginSettings.h"
 #include "PluginSystem.h"
 #include "PluginClass.h"
@@ skipping 628 matching lines @@
           CPluginDebug::DebugResultHiding(tagCString, "-", tagIt->second.m_filterText);
 #endif
         return true;
       }
     }
   }
 
   return false;
 }
 
-bool CPluginFilter::LoadHideFilters(std::vector<std::wstring> filters)
+bool CPluginFilter::LoadHideFilters(const std::vector<std::wstring>& filters)
 {
   ClearFilters();
+  m_hideFilters = filters;
   bool isRead = false;
   CPluginClient* client = CPluginClient::GetInstance();
 
   // Parse hide string
   int pos = 0;
   CriticalSection::Lock filterEngineLock(s_criticalSectionFilterMap);
   {
-    for (std::vector<std::wstring>::iterator it = filters.begin(); it < filters.end(); ++it)
+    for (std::vector<std::wstring>::const_iterator it = filters.begin(); it < filters.end(); ++it)
     {
       CString filter((*it).c_str());
       // If the line is not commented out
       if (!filter.Trim().IsEmpty() && filter.GetAt(0) != '!' && filter.GetAt(0) != '[')
       {
         int filterType = 0;
 
         // See http://adblockplus.org/en/filters for further documentation
 
         try
@@ skipping 23 matching lines @@
       for (int j = 0; j < 2; j++)
       {
         m_filterMap[i][j].clear();
       }
       m_filterMapDefault[i].clear();
     }
 
     m_elementHideTags.clear();
     m_elementHideTagsId.clear();
     m_elementHideTagsClass.clear();
+    m_hideFilters.clear();
   }
 }
 
 bool CPluginFilter::ShouldBlock(const std::wstring& src, int contentType, const std::wstring& domain, bool addDebug) const
 {
   CString srcCString = to_CString(src);
 
   // We should not block the empty string, so all filtering does not make sense
   // Therefore we just return
   if (srcCString.Trim().IsEmpty())
@@ skipping 26 matching lines @@
         CPluginDebug::DebugResultBlocking(type, srcCString, domain);
 #endif
     }
     return true;
   }
 #ifdef ENABLE_DEBUG_RESULT
   CPluginDebug::DebugResultIgnoring(type, srcCString, domain);
 #endif
   return false;
 }
+
+const std::vector<std::wstring>& CPluginFilter::getHideFilters() const
+{
+  DWORD res = WaitForSingleObject(hideFiltersLoadedEvent, ENGINE_STARTUP_TIMEOUT);

[Oleksandr, 2015/02/04 20:59:57]

It's hard to understand this from the scattered reviews, I just don't see it.
Where do we set this event?

[sergei, 2015/04/13 08:06:58]

`hideFiltersLoadedEvent` is not introduced in these changes, It's set in
PluginTabBase.cpp in `FilterLoader`. JIC, I'm sure that refactoring of
`hideFiltersLoadedEvent` should not be a part of this issue.

+  return m_hideFilters;
+}