Issue 2200 - PART II/II - Introduce --local and --remote parameters in {run,kick}.py

Note that this just allows for specifying a remote hosts.yaml resource - kicking and running inside vagrant is a future issue. See https://issues.adblockplus.org/ticket/2200 for more information..

[mathias, 2015-04-08 13:03:41]

Found a "<metavar>"..

[Wladimir Palant, 2015-04-08 14:59:34]

http://codereview.adblockplus.org/6572117575335936/diff/5668600916475904/run.py
File run.py (right):

http://codereview.adblockplus.org/6572117575335936/diff/5668600916475904/run....
run.py:59: path_name = '/etc/puppet/infrastructure/%s' %
("/".join(path_canonical),)
Please join paths properly:

import posixpath
path_name = posixpath.join('/etc/puppet/infrastructure', *path_canonical)

Using posixpath here because it should work independently of whatever OS this
script is running on.

http://codereview.adblockplus.org/6572117575335936/diff/5668600916475904/run....
run.py:64: child.wait()
Put yaml.load() into a try block and the two statements above into finally?

http://codereview.adblockplus.org/6572117575335936/diff/5668600916475904/run....
run.py:72: sys.exit(1)
The two lines above are equivalent to:

sys.exit('Please either specify a --remote host or use --local')

[mathias, 2015-04-08 15:29:08]

Done.

[mathias, 2015-04-08 15:29:58]

http://codereview.adblockplus.org/6572117575335936/diff/5668600916475904/run.py
File run.py (right):

http://codereview.adblockplus.org/6572117575335936/diff/5668600916475904/run....
run.py:14: '-u', '--user', metavar='user', dest='user', type=str,
default='vagrant',
Also removed this default, it's senseless until the next patch set (wich will be
in the context of another ticket), at least. And even then it should just apply
with --local and using ssh(1) instead of vagrant(1) - which is very much
unlikely.

http://codereview.adblockplus.org/6572117575335936/diff/5668600916475904/run....
run.py:59: path_name = '/etc/puppet/infrastructure/%s' %
("/".join(path_canonical),)
On 2015/04/08 14:59:35, Wladimir Palant wrote:
> Please join paths properly:
> 
> import posixpath
> path_name = posixpath.join('/etc/puppet/infrastructure', *path_canonical)
> 
> Using posixpath here because it should work independently of whatever OS this
> script is running on.

Done.

http://codereview.adblockplus.org/6572117575335936/diff/5668600916475904/run....
run.py:64: child.wait()
On 2015/04/08 14:59:35, Wladimir Palant wrote:
> Put yaml.load() into a try block and the two statements above into finally?

Done.

http://codereview.adblockplus.org/6572117575335936/diff/5668600916475904/run....
run.py:72: sys.exit(1)
On 2015/04/08 14:59:35, Wladimir Palant wrote:
> The two lines above are equivalent to:
> 
> sys.exit('Please either specify a --remote host or use --local')

Done.

[Wladimir Palant, 2015-04-08 16:36:35]

LGTM