common.gypi - Issue 6584950149087232: Issue 1280 - Update v8

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: common.gypi

Issue 6584950149087232: Issue 1280 - Update v8 (Closed)

Patch Set: get rid of auto and fix friends of JsValue Created Oct. 31, 2014, 5:11 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 {	1 {

2 'variables': {	2 'variables': {

3 'visibility%': 'hidden',	3 'visibility%': 'hidden',

4 'library%': 'static_library',	4 'library%': 'static_library',

5 'component%': '',	5 'component%': '',

6 'want_separate_host_toolset': 0,	6 'want_separate_host_toolset': 0,

	7 'v8_optimized_debug': 0,

	8 'v8_enable_i18n_support': 0,

7 },	9 },

8	10

9 'conditions': [	11 'conditions': [

10 ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \	12 ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \

11 or OS=="netbsd" or OS=="android"', {	13 or OS=="netbsd" or OS=="android"', {

12 'target_defaults': {	14 'target_defaults': {

13 'cflags': [ '-Wall', '-W', '-Wno-unused-parameter',	15 'cflags': [ '-Wall', '-W', '-Wno-unused-parameter',

14 '-Wnon-virtual-dtor', '-pthread', '-fno-rtti',	16 '-Wnon-virtual-dtor', '-pthread', '-fno-rtti',

15 '-pedantic', '-std=c++0x', '-fexceptions', ],	17 '-pedantic', '-std=c++0x', '-fexceptions', ],

16 'ldflags': [ '-pthread', ],	18 'ldflags': [ '-pthread', ],

(...skipping 15 matching lines...) Expand all Loading...
32 '-pthread', # Not supported by Android toolchain.	34 '-pthread', # Not supported by Android toolchain.

33 ],	35 ],

34 },	36 },

35 }],	37 }],

36 ],	38 ],

37	39

38 'target_defaults': {	40 'target_defaults': {

39 'msvs_cygwin_shell': 0,	41 'msvs_cygwin_shell': 0,

40 }	42 }

41 }	43 }

OLD	NEW