createsolution.bat - Issue 6584950149087232: Issue 1280 - Update v8 - Code Review

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code

Issues

Side by Side Diff: createsolution.bat

Issue 6584950149087232: Issue 1280 - Update v8 (Closed)

Patch Set: use msvs2012, because firstly it should go into our branch Created Oct. 27, 2014, 3:34 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

« no previous file with comments | « common.gypi ('k') | include/AdblockPlus/JsValue.h » ('j') | include/AdblockPlus/JsValue.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 @echo off	1 @echo off

2	2

3 pushd %~dp0	3 pushd %~dp0

4 mkdir build\ia32\shell	4 mkdir build\ia32\shell

5 mkdir build\x64\shell	5 mkdir build\x64\shell

6 python msvs_gyp_wrapper.py --depth=build\ia32 -f msvs -I common.gypi --generator -output=build\ia32 -G msvs_version=2012 -Dtarget_arch=ia32 libadblockplus.gyp	6 python msvs_gyp_wrapper.py --depth=build\ia32 -f msvs -I common.gypi --generator -output=build\ia32 -G msvs_version=2012 -Dtarget_arch=ia32 -Dhost_arch=ia32 liba dblockplus.gyp

7 python msvs_gyp_wrapper.py --depth=build\x64 -f msvs -I common.gypi --generator- output=build\x64 -G msvs_version=2012 -Dtarget_arch=x64 libadblockplus.gyp	7 python msvs_gyp_wrapper.py --depth=build\x64 -f msvs -I common.gypi --generator -output=build\x64 -G msvs_version=2012 -Dtarget_arch=x64 -Dhost_arch=x64 liba dblockplus.gyp
	Felix Dahlke 2014/10/31 05:31:57 We generally don't align code in columns, so I'd v We generally don't align code in columns, so I'd vote against the spaces after x64. sergei 2014/10/31 11:47:01 I've removed such spaces. Could you explain the ad Show quoted text On 2014/10/31 05:31:57, Felix H. Dahlke wrote: > We generally don't align code in columns, so I'd vote against the spaces after > x64. I've removed such spaces. Could you explain the advantage of it? I like to align code in columns because for me it improves the readability and simplifies error checking. The used parameters as well as the difference are immediately visible, it's easier to edit them, one can use multicursor input to add or to remove parameters. Felix Dahlke 2014/10/31 15:07:51 I don't have a strong opinion actually. The only c Show quoted text On 2014/10/31 11:47:01, sergei wrote: > On 2014/10/31 05:31:57, Felix H. Dahlke wrote: > > We generally don't align code in columns, so I'd vote against the spaces after > > x64. > > I've removed such spaces. > Could you explain the advantage of it? > I like to align code in columns because for me it improves the readability and > simplifies error checking. The used parameters as well as the difference are > immediately visible, it's easier to edit them, one can use multicursor input to > add or to remove parameters. I don't have a strong opinion actually. The only coding style topic really worth arguing about in my mind is consistency, and indenting on column is not something we do anywhere. sergei 2014/10/31 16:13:35 BTW, don't mix indenting and alignment, here are t Show quoted text On 2014/10/31 15:07:51, Felix H. Dahlke wrote: > On 2014/10/31 11:47:01, sergei wrote: > > On 2014/10/31 05:31:57, Felix H. Dahlke wrote: > > > We generally don't align code in columns, so I'd vote against the spaces > after > > > x64. > > > > I've removed such spaces. > > Could you explain the advantage of it? > > I like to align code in columns because for me it improves the readability and > > simplifies error checking. The used parameters as well as the difference are > > immediately visible, it's easier to edit them, one can use multicursor input > to > > add or to remove parameters. > > I don't have a strong opinion actually. The only coding style topic really worth > arguing about in my mind is consistency, and indenting on column is not > something we do anywhere. BTW, don't mix indenting and alignment, here are tabs for indentation http://2.bp.blogspot.com/-FMTWlpzeT-Y/UK94k7hZuBI/AAAAAAAAASI/VI1HzcucYT4/s16... Felix Dahlke 2014/10/31 16:30:15 Yeah, aligning it is. Show quoted text On 2014/10/31 16:13:35, sergei wrote: > On 2014/10/31 15:07:51, Felix H. Dahlke wrote: > > On 2014/10/31 11:47:01, sergei wrote: > > > On 2014/10/31 05:31:57, Felix H. Dahlke wrote: > > > > We generally don't align code in columns, so I'd vote against the spaces > > after > > > > x64. > > > > > > I've removed such spaces. > > > Could you explain the advantage of it? > > > I like to align code in columns because for me it improves the readability > and > > > simplifies error checking. The used parameters as well as the difference are > > > immediately visible, it's easier to edit them, one can use multicursor input > > to > > > add or to remove parameters. > > > > I don't have a strong opinion actually. The only coding style topic really > worth > > arguing about in my mind is consistency, and indenting on column is not > > something we do anywhere. > > BTW, don't mix indenting and alignment, here are tabs for indentation > http://2.bp.blogspot.com/-FMTWlpzeT-Y/UK94k7hZuBI/AAAAAAAAASI/VI1HzcucYT4/s16... Yeah, aligning it is.
8 popd	8 popd

OLD	NEW

« no previous file with comments | « common.gypi ('k') | include/AdblockPlus/JsValue.h » ('j') | include/AdblockPlus/JsValue.h » ('J')

Powered by Google App Engine

This is Rietveld