createsolution.bat - Issue 6584950149087232: Issue 1280 - Update v8

Delta Between Two Patch Sets: createsolution.bat

Issue 6584950149087232: Issue 1280 - Update v8 (Closed)

Left Patch Set: use msvs2012, because firstly it should go into our branch Created Oct. 27, 2014, 3:34 p.m.

Right Patch Set: revert not critical chanegs in JsValue ctr Created Nov. 3, 2014, 2:49 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 @echo off	1 @echo off

2	2

3 pushd %~dp0	3 pushd %~dp0

4 mkdir build\ia32\shell	4 mkdir build\ia32\shell

5 mkdir build\x64\shell	5 mkdir build\x64\shell

6 python msvs_gyp_wrapper.py --depth=build\ia32 -f msvs -I common.gypi --generator -output=build\ia32 -G msvs_version=2012 -Dtarget_arch=ia32 -Dhost_arch=ia32 liba dblockplus.gyp	6 python msvs_gyp_wrapper.py --depth=build\ia32 -f msvs -I common.gypi --generator -output=build\ia32 -G msvs_version=2012 -Dtarget_arch=ia32 -Dhost_arch=ia32 liba dblockplus.gyp

7 python msvs_gyp_wrapper.py --depth=build\x64 -f msvs -I common.gypi --generator -output=build\x64 -G msvs_version=2012 -Dtarget_arch=x64 -Dhost_arch=x64 liba dblockplus.gyp	7 python msvs_gyp_wrapper.py --depth=build\x64 -f msvs -I common.gypi --generator- output=build\x64 -G msvs_version=2012 -Dtarget_arch=x64 -Dhost_arch=x64 libadblo ckplus.gyp
Felix Dahlke 2014/10/31 05:31:57 We generally don't align code in columns, so I'd v We generally don't align code in columns, so I'd vote against the spaces after x64. sergei 2014/10/31 11:47:01 I've removed such spaces. Could you explain the ad Show quoted text On 2014/10/31 05:31:57, Felix H. Dahlke wrote: > We generally don't align code in columns, so I'd vote against the spaces after > x64. I've removed such spaces. Could you explain the advantage of it? I like to align code in columns because for me it improves the readability and simplifies error checking. The used parameters as well as the difference are immediately visible, it's easier to edit them, one can use multicursor input to add or to remove parameters. Felix Dahlke 2014/10/31 15:07:51 I don't have a strong opinion actually. The only c Show quoted text On 2014/10/31 11:47:01, sergei wrote: > On 2014/10/31 05:31:57, Felix H. Dahlke wrote: > > We generally don't align code in columns, so I'd vote against the spaces after > > x64. > > I've removed such spaces. > Could you explain the advantage of it? > I like to align code in columns because for me it improves the readability and > simplifies error checking. The used parameters as well as the difference are > immediately visible, it's easier to edit them, one can use multicursor input to > add or to remove parameters. I don't have a strong opinion actually. The only coding style topic really worth arguing about in my mind is consistency, and indenting on column is not something we do anywhere. sergei 2014/10/31 16:13:35 BTW, don't mix indenting and alignment, here are t Show quoted text On 2014/10/31 15:07:51, Felix H. Dahlke wrote: > On 2014/10/31 11:47:01, sergei wrote: > > On 2014/10/31 05:31:57, Felix H. Dahlke wrote: > > > We generally don't align code in columns, so I'd vote against the spaces > after > > > x64. > > > > I've removed such spaces. > > Could you explain the advantage of it? > > I like to align code in columns because for me it improves the readability and > > simplifies error checking. The used parameters as well as the difference are > > immediately visible, it's easier to edit them, one can use multicursor input > to > > add or to remove parameters. > > I don't have a strong opinion actually. The only coding style topic really worth > arguing about in my mind is consistency, and indenting on column is not > something we do anywhere. BTW, don't mix indenting and alignment, here are tabs for indentation http://2.bp.blogspot.com/-FMTWlpzeT-Y/UK94k7hZuBI/AAAAAAAAASI/VI1HzcucYT4/s16... Felix Dahlke 2014/10/31 16:30:15 Yeah, aligning it is. Show quoted text On 2014/10/31 16:13:35, sergei wrote: > On 2014/10/31 15:07:51, Felix H. Dahlke wrote: > > On 2014/10/31 11:47:01, sergei wrote: > > > On 2014/10/31 05:31:57, Felix H. Dahlke wrote: > > > > We generally don't align code in columns, so I'd vote against the spaces > > after > > > > x64. > > > > > > I've removed such spaces. > > > Could you explain the advantage of it? > > > I like to align code in columns because for me it improves the readability > and > > > simplifies error checking. The used parameters as well as the difference are > > > immediately visible, it's easier to edit them, one can use multicursor input > > to > > > add or to remove parameters. > > > > I don't have a strong opinion actually. The only coding style topic really > worth > > arguing about in my mind is consistency, and indenting on column is not > > something we do anywhere. > > BTW, don't mix indenting and alignment, here are tabs for indentation > http://2.bp.blogspot.com/-FMTWlpzeT-Y/UK94k7hZuBI/AAAAAAAAASI/VI1HzcucYT4/s16... Yeah, aligning it is.
8 popd	8 popd

LEFT	RIGHT