Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/JsEngine.cpp

Issue 6584950149087232: Issue 1280 - Update v8 (Closed)
Patch Set: get rid of auto and fix friends of JsValue Created Oct. 31, 2014, 5:11 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/JsEngine.cpp
--- a/src/JsEngine.cpp
+++ b/src/JsEngine.cpp
@@ -55,9 +55,9 @@
const v8::Locker locker(result->isolate);
const v8::HandleScope handleScope;
- result->context.reset(result->isolate, v8::Context::New());
+ result->context.reset(result->isolate, v8::Context::New(result->isolate));
AdblockPlus::GlobalJsObject::Setup(result, appInfo,
- JsValuePtr(new JsValue(result, result->context->Global())));
+ JsValuePtr(new JsValue(result, v8::Local<v8::Context>::New(result->isolate, result->context)->Global())));
Wladimir Palant 2014/11/01 22:30:25 Why do you need to create a new handle for the con
sergei 2014/11/03 12:58:19 Not sure that I correctly understand what you mean
Felix Dahlke 2014/11/03 15:46:24 I see. Looked through the docs a bit, unfortunatel
Wladimir Palant 2014/11/03 18:06:33 I see, so v8::Persistent cannot be used as a handl
return result;

Powered by Google App Engine
This is Rietveld