Issue 419 - Work around WebKit bug which breaks element hiding on Safari

lib/elemHide.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 373 matching lines @@
   /**
    * Retrieves an element hiding filter by the corresponding protocol key
    */
   getFilterByKey: function(/**String*/ key) /**Filter*/
   {
     return (key in filterByKey ? filterByKey[key] : null);
   },
 
   /**
    * Returns a list of all selectors active on a particular domain (currently
-   * used only in Chrome).
+   * used only in Chrome, Opera and Safari).
    */
   getSelectorsForDomain: function(/**String*/ domain, /**Boolean*/ specificOnly)
   {
     let result = [];
     for (let key in filterByKey)
     {
       let filter = filterByKey[key];
-      if (specificOnly && (!filter.domains || filter.domains[""]))
+      let domains = filter.domains; // it is important to always access filter.domains
+                                    // here, even if it isn't used, in order to
+                                    // workaround WebKit bug 132872, also see #419

[Wladimir Palant, 2014/05/14 06:17:37]

Nit: Please always put comments with more than two words before the line you are
commenting on - they are easier to see and read there, and you have more space
(your comment exceeds 80 characters line length).

[Sebastian Noack, 2014/05/14 06:40:19]

Done.

+
+      if (specificOnly && (!domains || domains[""]))
         continue;
 
       if (filter.isActiveOnDomain(domain) && !this.getException(filter, domain))
         result.push(filter.selector);
     }
     return result;
   }
 };