include.postload.js - Issue 6609231193047040: Noissue - Removed dead code passing coordinates for "Block elements" dialog

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: include.postload.js

Issue 6609231193047040: Noissue - Removed dead code passing coordinates for "Block elements" dialog (Closed)

Patch Set: Created March 27, 2015, 11:12 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: include.postload.js

===================================================================

--- a/include.postload.js

+++ b/include.postload.js

@@ -250,7 +250,7 @@

// Show dialog asking user whether she wants to add the proposed filters derived

// from selected page element

-function clickHide_showDialog(left, top, filters)

+function clickHide_showDialog(filters)

{

// If we are already selecting, abort now

if (clickHide_activated)

@@ -530,8 +530,6 @@

payload:

{

type: "clickhide-show-dialog",

- screenX: e.screenX,

- screenY: e.screenY,

clickHideFilters: filters

}

});

@@ -727,9 +725,7 @@

break;

case "clickhide-show-dialog":

if (window.self == window.top)

- clickHide_showDialog(msg.screenX + window.pageXOffset,

- msg.screenY + window.pageYOffset,

- msg.clickHideFilters);

+ clickHide_showDialog(msg.clickHideFilters);

break;

case "clickhide-clear-last-right-click-event":

if (lastRightClickEventValid)

« no previous file with comments | « no previous file | no next file » | no next file with comments »