Issue 1268 - Correctly mimic Chrome's behavior when opening the options page

chrome/ext/background.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 347 matching lines @@
       }
     };
 
     return ext.onMessage._dispatch(message, sender, sendResponse);
   });
 
 
   /* Storage */
 
   ext.storage = localStorage;
+
+
+  /* Options */
+
+  ext.showOptions = function(callback)
+  {
+    chrome.windows.getLastFocused(function(win)
+    {
+      var optionsUrl = chrome.extension.getURL("options.html");
+      var queryInfo = {url: optionsUrl};
+
+      // extension pages can't be accessed in incognito windows. In order to
+      // correctly mimic the way in which Chrome opens extension options,
+      // we have to focus the options page in any other window.
+      if (!win.incognito)
+        queryInfo.windowId = win.id;
+
+      chrome.tabs.query(queryInfo, function(tabs)
+      {
+        if (tabs.length > 0)
+        {
+          var tab = tabs[0];
+
+          chrome.windows.update(tab.windowId, {focused: true});
+          chrome.tabs.update(tab.id, {selected: true});
+
+          if (callback)
+            callback(new Page(tab));
+        }
+        else
+        {
+          ext.pages.open(optionsUrl, callback);
+        }
+      });
+    });
+  };
 })();