Noissue - Document the prefs module

lib/prefs.js

Index: lib/prefs.js
===================================================================
--- a/lib/prefs.js
+++ b/lib/prefs.js
@@ -15,35 +15,153 @@
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+/** @module prefs */
+
 const keyPrefix = "pref:";
 
+/** @lends module:prefs.Prefs */
 let defaults = Object.create(null);
 let overrides = Object.create(null);
 
+/**
+ * Only for compatibility with core code. Please do not change!
+ *
+ * @type {boolean}
+ */
 defaults.enabled = true;
+/**
+ * The application version as set during initialization. Used to detect updates.
+ *
+ * @type {string}
+ */
 defaults.currentVersion = "";
+/**
+ * Only for compatibility with core code. Please do not change!
+ *
+ * @type {string}
+ */
 defaults.data_directory = "";
+/**
+ * @see https://adblockplus.org/en/preferences#patternsbackups
+ * @type {number}
+ */
 defaults.patternsbackups = 5;
+/**
+ * @see https://adblockplus.org/en/preferences#patternsbackupinterval
+ * @type {number}
+ */
 defaults.patternsbackupinterval = 24;
+/**
+ * Only for compatibility with core code. Please do not change!
+ *
+ * @type {boolean}
+ */
 defaults.savestats = false;
+/**
+ * Only for compatibility with core code. Please do not change!
+ *
+ * @type {boolean}
+ */
 defaults.privateBrowsing = false;
+/**
+ * @see https://adblockplus.org/en/preferences#subscriptions_fallbackerrors
+ * @type {number}
+ */
 defaults.subscriptions_fallbackerrors = 5;
+/**
+ * @see https://adblockplus.org/en/preferences#subscriptions_fallbackurl
+ * @type {string}
+ */
 defaults.subscriptions_fallbackurl = "https://adblockplus.org/getSubscription?version=%VERSION%&url=%SUBSCRIPTION%&downloadURL=%URL%&error=%ERROR%&channelStatus=%CHANNELSTATUS%&responseStatus=%RESPONSESTATUS%";
+/**
+ * @see https://adblockplus.org/en/preferences#subscriptions_autoupdate
+ * @type {boolean}
+ */
 defaults.subscriptions_autoupdate = true;
+/**
+ * @see https://adblockplus.org/en/preferences#subscriptions_exceptionsurl
+ * @type {string}
+ */
 defaults.subscriptions_exceptionsurl = "https://easylist-downloads.adblockplus.org/exceptionrules.txt";
+/**
+ * @see https://adblockplus.org/en/preferences#subscriptions_antiadblockurl
+ * @type {string}
+ */
 defaults.subscriptions_antiadblockurl = "https://easylist-downloads.adblockplus.org/antiadblockfilters.txt";
+/**
+ * @see https://adblockplus.org/en/preferences#documentation_link
+ * @type {string}
+ */
 defaults.documentation_link = "https://adblockplus.org/redirect?link=%LINK%&lang=%LANG%";
+/**
+ * @see https://adblockplus.org/en/preferences#notificationdata
+ * @type {object}
+ */
 defaults.notificationdata = {};
+/**
+ * @see https://adblockplus.org/en/preferences#notificationurl
+ * @type {string}
+ */
 defaults.notificationurl = "https://notification.adblockplus.org/notification.json";
+/**
+ * The total number of ads blocked on all pages.
+ *
+ * @type {object}
+ * @property {number} [blocked]
+ */
 defaults.stats_total = {};
+/**
+ * Whether to show a badge in the toolbar icon indicating the number of blocked ads.
+ *
+ * @type {boolean}
+ */
 defaults.show_statsinicon = true;
+/**
+ * Whether to show the number of blocked ads in the popup.
+ *
+ * @type {boolean}
+ */
 defaults.show_statsinpopup = true;
+/**
+ * Whether to show the "Block element" context menu entry.
+ *
+ * @type {boolean}
+ */
 defaults.shouldShowBlockElementMenu = true;
+/**
+ * Whether to collapse placeholders for blocked elements.
+ *
+ * @type {boolean}
+ */
 defaults.hidePlaceholders = true;
+/**
+ * Whether to suppress the first run page. This preference isn't
+ * set by the extension but can be pre-configured externally.
+ *
+ * @see https://adblockplus.org/development-builds/suppressing-the-first-run-page-on-chrome

[Sebastian Noack, 2015/04/18 14:36:27]

Note that this page isn't up yet, but will be at the time this change is going
to be pushed.

+ * @type {boolean}
+ */
 defaults.suppress_first_run_page = false;
 
+/**
+  * @namespace
+  * @static
+  */
 let Prefs = exports.Prefs = {
+  /**
+   * Fired when the value of a preference changes.
+   *
+   * @event
+   * @property {string} pref The name of the preference that changed.
+   */
   onChanged: new ext._EventTarget(),
+
+  /**
+   * Fired when all preferences have been loaded. You must wait for
+   * this event before using preferences during extension initialization.
+   *
+   * @event
+   */
   onLoaded: new ext._EventTarget()
 };