Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(408)

Issue 6658724257071104: Implement empty Utils.yield in Chrome, Opera and Safari (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by Thomas Greiner
Modified:
5 years, 11 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

This is part of https://issues.adblockplus.org/ticket/189 and is required for the current adblockpluschrome devbuild to initialize properly.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M lib/utils.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Thomas Greiner
5 years, 11 months ago (2014-03-22 22:36:41 UTC) #1
Wladimir Palant
5 years, 11 months ago (2014-03-23 09:12:56 UTC) #2
LGTM but this really only solves a small part of the problem. Without
considering FilterStorage.firstRun a new install won't initialize properly.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5