Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(74)

Issue 6700499810123776: Issue 520 - Add German and Russian translation to PAD files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by Sebastian Noack
Modified:
5 years, 5 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 520 - Add German and Russian translation to PAD files

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -8 lines) Patch
M sitescripts/extensions/pad/language.py View 1 chunk +3 lines, -0 lines 0 comments Download
M sitescripts/extensions/pad/validation.py View 4 chunks +12 lines, -7 lines 0 comments Download
M sitescripts/extensions/template/pad.xml View 2 chunks +108 lines, -1 line 0 comments Download

Messages

Total messages: 3
Sebastian Noack
5 years, 5 months ago (2014-06-12 13:55:30 UTC) #1
Wladimir Palant
Quite a mess... This makes me really wish that the descriptions are read from the ...
5 years, 5 months ago (2014-06-13 09:19:58 UTC) #2
Sebastian Noack
5 years, 5 months ago (2014-06-13 09:45:54 UTC) #3
On 2014/06/13 09:19:58, Wladimir Palant wrote:
> Quite a mess... This makes me really wish that the descriptions are read from
> the corresponding locale files properly. Also, updating validation rules will
be
> a lot harder now.
> 
> Still LGTM I guess.

I agree. But I don't have any better idea.

Putting the descriptions in the locale files in the extension's repo has some
flaws:
1. You would need to parse different locale formats.
2. You wouldn't be able to share descriptions or parts of them across extensions
anymore.
3. And you might not be able anymore to change the description without releasing
a new version.

Putting the descriptions into separate files inside the sitescripts repo might
work. But that approach would also become rather complex if you want to achieve
full flexibility, but also want to be able to reuse descriptions that are the
same for multiple extensions.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5