Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: pages/requirements.tmpl

Issue 6702768332996608: Issue 2432 - Auto-generate browser versions on requirements page (Closed)
Left Patch Set: Rewrite Created April 30, 2015, 11:33 a.m.
Right Patch Set: Removed build ID an try-block for SeaMonkey Aurora and Nightly Created May 15, 2015, 10:19 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « globals/get_browser_versions.py ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 title=Adblock Plus system requirements 1 title=Adblock Plus system requirements
2 2
3 {%- macro browser_versions(browser_name, internal_name, versions) %} 3 {%- macro browser_versions(browser_name, internal_name, versions) %}
4 <h2 id="{{ internal_name }}">{{ browser_name }}</h2> 4 <h2 id="{{ internal_name }}">{{ browser_name }}</h2>
5 <ul> 5 <ul>
6 {%- set versions = versions or get_browser_versions(internal_name) %} 6 {%- set versions = versions or get_browser_versions(internal_name) %}
7 {%- if versions.previous %} 7 {%- if versions.previous %}
8 <li>{{ browser_name }} {{ versions.previous }}</li> 8 <li>{{ browser_name }} {{ versions.previous }}</li>
9 {%- endif %} 9 {%- endif %}
10 <li>{{ browser_name }} {{ versions.current }}</li> 10 <li>{{ browser_name }} {{ versions.current }}</li>
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 <li>Internet Explorer 11</li> 42 <li>Internet Explorer 11</li>
43 </ul> 43 </ul>
44 44
45 {{ browser_versions("Yandex.Browser", "yandex") }} 45 {{ browser_versions("Yandex.Browser", "yandex") }}
46 46
47 {{ browser_versions("Firefox Mobile", "fennec", firefox_versions) }} 47 {{ browser_versions("Firefox Mobile", "fennec", firefox_versions) }}
48 48
49 {{ browser_versions("SeaMonkey", "seamonkey") }} 49 {{ browser_versions("SeaMonkey", "seamonkey") }}
50 50
51 {{ browser_versions("Thunderbird", "thunderbird") }} 51 {{ browser_versions("Thunderbird", "thunderbird") }}
LEFTRIGHT

Powered by Google App Engine
This is Rietveld