Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(132)

Issue 6751260996796416: Issue 1724 - Fixed memory leak in messaging code, when no response is sent, on Safari (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by Sebastian Noack
Modified:
5 years, 1 month ago
Reviewers:
Wladimir Palant, kzar
Visibility:
Public.

Description

Issue 1724 - Fixed memory leak in messaging code, when no response is sent, on Safari

Patch Set 1 #

Total comments: 8

Patch Set 2 : Addressed comments #

Patch Set 3 : Prevent the request payload from being sent back with fallback responses #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -19 lines) Patch
M chrome/ext/background.js View 1 chunk +8 lines, -1 line 0 comments Download
M ext/common.js View 2 chunks +4 lines, -10 lines 0 comments Download
M safari/ext/background.js View 1 chunk +3 lines, -2 lines 0 comments Download
M safari/ext/common.js View 1 2 2 chunks +23 lines, -6 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
5 years, 1 month ago (2015-01-08 14:16:05 UTC) #1
Wladimir Palant
There we go, Safari and Firefox implementations diverge already :) http://codereview.adblockplus.org/6751260996796416/diff/5629499534213120/safari/ext/common.js File safari/ext/common.js (right): http://codereview.adblockplus.org/6751260996796416/diff/5629499534213120/safari/ext/common.js#newcode52 ...
5 years, 1 month ago (2015-01-08 14:28:18 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/6751260996796416/diff/5629499534213120/safari/ext/common.js File safari/ext/common.js (right): http://codereview.adblockplus.org/6751260996796416/diff/5629499534213120/safari/ext/common.js#newcode52 safari/ext/common.js:52: // is sent later asynchronously. Otherwise if no response ...
5 years, 1 month ago (2015-01-08 14:36:13 UTC) #3
Wladimir Palant
LGTM Now all we need is change the Firefox implementation to match...
5 years, 1 month ago (2015-01-08 14:45:25 UTC) #4
Wladimir Palant
5 years, 1 month ago (2015-01-08 15:58:56 UTC) #5
LGTM again.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5